From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] perl: Testsuite: Add test for lookup_asn()
Date: Tue, 01 Oct 2019 12:56:32 +0100
Message-ID: <7A424E1A-03D5-47A4-B4F0-2F1D50D37A5F@ipfire.org>
In-Reply-To: <20191001062429.4931-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7073885055065089918=="
List-Id: <location.lists.ipfire.org>

--===============7073885055065089918==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 1 Oct 2019, at 07:24, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/perl/t/Location.t | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/src/perl/t/Location.t b/src/perl/t/Location.t
> index aef15c3..af5e258 100644
> --- a/src/perl/t/Location.t
> +++ b/src/perl/t/Location.t
> @@ -11,7 +11,7 @@ use warnings;
> # Where to find the test database.
> my $testdb =3D "../../testdata/test.db";
>=20
> -use Test::More tests =3D> 5;
> +use Test::More tests =3D> 6;
> BEGIN { use_ok('Location') };
>=20
> #########################
> @@ -36,3 +36,6 @@ ok($description eq "This is a geo location database", "Te=
st 3 - Get Database Des
>=20
> my $country_code =3D &Location::lookup_country_code($db, $address);
> ok($country_code eq "DE", "Test 4 - Lookup country code for $address");
> +
> +my $as_number =3D &Location::lookup_asn($db, $address);
> +ok($as_number eq "204867", "Test 5 - Lookup Autonomous System for $address=
=E2=80=9D);

You should also test functions like this for invalid inputs and check if you =
get the correct response.

That would be two things here:

1) An invalid IP address like (a.b.c.d)
2) A valid IP address, but which is not in the database

You can submit that as an extra patch.

-Michael

> --=20
> 2.20.1
>=20


--===============7073885055065089918==--