Re: Upload libloc to Debian

[Michael Tremer <michael.tremer@ipfire.org>]

Hello,

> On 23 Mar 2025, at 08:31, Hans-Christoph Steiner <hans@guardianproject.info> wrote:
> 
> Hey Michael,
> 
> Great to hear about all your work on libloc, it is really a key package.  One possibility that might streamline things is if you maintained your Debian packaging in https://salsa.debian.org/debian/libloc/ or as a fork of it.  That already includes a lot of tests around the Debian package and integration:
> https://salsa.debian.org/debian/libloc/-/pipelines/836918

I agree that it would be nice to get these things closer together. I however remember that there were some problems that I discussed with Jochen some long time ago and which I cannot remember any more :) Those were a mix of me having very little experience with the Debian build system, different requirements for the different releases (trixie seems to have a different package naming system for libraries) and therefore massive confusion on my part. I also have no interest in publishing any packages outside for the purpose of development, so I didn’t think it was worth to spend any time on this.

Any pointers on how we can make this all go together? I believe the closer the two repositories are to each other, the less work for all of us.

> Then for your CI, you could make the CI job copy the debian/ dir from that repo.  And then there would be no need to maintain the debian/ dir in the libloc git repo.

But how do I build my test packages then? I need to be able to make changes as well.

> I uploaded 0.9.18, it is in unstable awaiting the autopkgtest run.  0.9.17 made it into trixie already.

Thank you very much! Let me know if there are any problems.

Looking through the files I noticed a security contact here: https://salsa.debian.org/debian/libloc/-/blob/master/debian/upstream/metadata?ref_type=heads; Could you please add security@ipfire.org <mailto:security@ipfire.org> or a note that people can check a box on Bugzilla to submit a non-public ticket? The Git repository should also be https://git.ipfire.org/?p=location/libloc.git;a=summary as I don’t think we will continue using GitHub that much longer. It only serves as a mirror with no other benefit for us.

Best,
-Michael

> 
> All the best,
> Hans
> 
> Michael Tremer:
>> Hello,
>> Great! Let me know whenever I can help testing or whether you need any changes.
>> In the meantime I have been setting up a little Jenkins pipeline which should help us to provide better releases. There could be done much more here, but for that I would require some more time i.e. funding…
>> The current status is here: https://jenkins.ipfire.org/job/libloc/
>> But so far we are building for Debian, Ubuntu, Fedora and Archlinux. We are also building Debian packages for pretty much all supported architectures which are amd64, arm64, armel, armhf, i386, ppc64el, s390x. This has already helped me finding a big-endian issue which is fixed here:
>>   https://git.ipfire.org/?p=location/libloc.git;a=commitdiff;h=afc5330f56d74b4a9142b800d994d623d7cd29e8
>> The pipeline outputs some Debian packages. These are not supported to be used by regular users, because I would rather have the latest version of our package in the official distribution. They are however useful for testing because I can install them really quick wherever I need them. Therefore it would be great if these packages would be as close to upstream as possible so that we are actually testing the same thing. I would be happy to receive patches if you are up for that.
>> Best,
>> -Michael
>>> On 19 Mar 2025, at 09:10, Hans-Christoph Steiner <hans@guardianproject.info> wrote:
>>> 
>>> 
>>> I uploaded 0.9.17 to Debian already, and will upload 0.9.18 once 0.9.17 is in testing.  After 0.9.18 makes it to testing, I'll try enabling the lua-location binary package, it looks easy.  It'll have to go through the NEW queue, so it might not make it into trixie/testing.
>>> 
>>> Michael Tremer:
>>>> Hello everyone,
>>>> I have a release tagged here: https://source.ipfire.org/releases/libloc/libloc-0.9.18.tar.gz
>>>> https://git.ipfire.org/?p=location/libloc.git;a=shortlog;h=8cbdc19cda26d37dca354135c2825fa6a4d94ff4
>>>> Please let me know if you find any regressions.
>>>> Best,
>>>> -Michael
>>>>> On 6 Mar 2025, at 10:48, Michael Tremer <michael.tremer@ipfire.org> wrote:
>>>>> 
>>>>> Hello Hans,
>>>>> 
>>>>> Thanks for your email.
>>>>> 
>>>>> Yes, there has been a lot of work being going into the library in the past year. We have made huge improvements to the importer which now several orders of magnitude faster, we have added Lua bindings and generally improved stability and performance. However, I don’t remember where I have left off. Time has been running out.
>>>>> 
>>>>> It would be great to have the latest changes in Debian, because Trixie is coming up fast. We should definitely have the latest version in the release whenever it will come out.
>>>>> 
>>>>> Is there a deadline for all of this? I would have to squeeze a release into my schedule and first of all making sure that we are releasing good software without introducing any new problems.
>>>>> 
>>>>> -Michael
>>>>> 
>>>>>> On 5 Mar 2025, at 18:25, Hans-Christoph Steiner <hans@guardianproject.info> wrote:
>>>>>> 
>>>>>> 
>>>>>> Hey IPFire crew!
>>>>>> 
>>>>>> I'm just looking at updating libloc in Debian.  It looks like there are a lot of commits in git that are not part of a release.  Do you have plans to make a release soon?
>>>>>> 
>>>>>> All the best,
>>>>>> Hans
>>>>>> 
>>>>>> Michael Tremer:
>>>>>>> Hello everyone,
>>>>>>> HC, thank you for your contribution to our little project. If you find anything else, please feel free to send patches.
>>>>>>> And thank you Stefan for getting this into the repository.
>>>>>>> Best,
>>>>>>> -Michael
>>>>>>>> On 2 Mar 2023, at 16:19, Stefan Schantl <stefan.schantl@ipfire.org> wrote:
>>>>>>>> 
>>>>>>>> Hello Hans-Christoph,
>>>>>>>> 
>>>>>>>> a big thanks for writing and sharing your script. I've added it to the
>>>>>>>> official libloc source code by the following commit:
>>>>>>>> 
>>>>>>>> ttps://git.ipfire.org/?p=location/libloc.git;a=commit;h=02a7d6ec0bb79f9
>>>>>>>> 62ffe0746d311b3454b11a3db
>>>>>>>> 
>>>>>>>> Best regards,
>>>>>>>> 
>>>>>>>> -Stefan
>>>>>>>>> 
>>>>>>>>> Hey all,
>>>>>>>>> 
>>>>>>>>> I just uploaded a new version of the libloc Debian package that
>>>>>>>>> includes bash
>>>>>>>>> completion for the 'location' command.  I would like to see this file
>>>>>>>>> included
>>>>>>>>> upstream in your git, so it is also attached to the email.
>>>>>>>>> 
>>>>>>>>> If you want to try it, either install location 0.9.16-2 from Debian,
>>>>>>>>> or stick
>>>>>>>>> the attached file in /etc/bash_completion.d/location and open a new
>>>>>>>>> bash shell.
>>>>>>>>> 
>>>>>>>>> .hc
>>>>>>>>> 
>>>>>>>>> Jochen Sprickerhof:
>>>>>>>>>> Hi Michael,
>>>>>>>>>> 
>>>>>>>>>> * Michael Tremer <michael.tremer@ipfire.org> [2022-08-16 10:00]:
>>>>>>>>>>>> https://buildd.debian.org/status/package.php?p=libloc
>>>>>>>>>>> 
>>>>>>>>>>> I installed a virtual machine with mips64el and the testsuite
>>>>>>>>>>> weirdly runs
>>>>>>>>>>> through.
>>>>>>>>>> 
>>>>>>>>>> I was able to reproduce it using ppc64el:
>>>>>>>>>> 
>>>>>>>>>> # echo "deb-src http://deb.debian.org/debian unstable main" >>
>>>>>>>>>> /etc/apt/sources.list
>>>>>>>>>> # apt update
>>>>>>>>>> # apt build-dep libloc
>>>>>>>>>> # apt source --compile libloc
>>>>>>>>>> 
>>>>>>>>>> Interestingly the new version now also fails on mipsel, so maybe it
>>>>>>>>>> is a flaky
>>>>>>>>>> test?
>>>>>>>>>> 
>>>>>>>>>> https://buildd.debian.org/status/logs.php?pkg=libloc&arch=mipsel
>>>>>>>>>> 
>>>>>>>>>> Given that it compiled before this means we should try to fix the
>>>>>>>>>> bug as it is
>>>>>>>>>> blocks testing migration, otherwise:
>>>>>>>>>> 
>>>>>>>>>> https://tracker.debian.org/pkg/libloc
>>>>>>>>>> 
>>>>>>>>>> (The other option would be to request removal of the old mipsel
>>>>>>>>>> version.)
>>>>>>>>>> 
>>>>>>>>>>> Additionally, the packages don’t build for Debian any more using
>>>>>>>>>>> my script.
>>>>>>>>>>> 
>>>>>>>>>>> I opened a bug ticket with the error here:
>>>>>>>>>>> https://bugzilla.ipfire.org/show_bug.cgi?id=12912
>>>>>>>>>> 
>>>>>>>>>> Looks like you try to cross build (installing crossbuild-essential-
>>>>>>>>>> arm64:amd64),
>>>>>>>>>> maybe that's currently broken. You can try installing qemu-user-
>>>>>>>>>> static and
>>>>>>>>>> replace --host with --arch in debian/build.sh.
>>>>>>>>>> Btw. sbuild updates the chroot before building so there should be
>>>>>>>>>> no need to
>>>>>>>>>> throw it away (for a stable release).
>>>>>>>>>> 
>>>>>>>>>> Cheers Jochen
>>>>>>>>> 
>>>>>>>>> -- 
>>>>>>>>> Signal: +13478504872
>>>>>>>>> PGP fingerprint: EE66 20C7 136B 0D2C 456C  0A4D E9E2 8DEA 00AA 5556
>>>>>>>>> https://keys.openpgp.org/search?q=EE6620C7136B0D2C456C0A4DE9E28DEA00AA5556
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>>>> -- 
>>>>>> Signal: +13478504872
>>>>>> PGP fingerprint: EE66 20C7 136B 0D2C 456C  0A4D E9E2 8DEA 00AA 5556
>>>>> 
>>> 
>>> -- 
>>> Signal: +13478504872
>>> PGP fingerprint: EE66 20C7 136B 0D2C 456C  0A4D E9E2 8DEA 00AA 5556
> 
> -- 
> Signal: +13478504872
> PGP fingerprint: EE66 20C7 136B 0D2C 456C  0A4D E9E2 8DEA 00AA 5556