From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: location@lists.ipfire.org Subject: Re: [PATCH] debian: Rework historical changelog Date: Wed, 14 Apr 2021 10:28:22 +0100 Message-ID: <7EADC7AB-81DE-40DD-9A42-FD86854349EE@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3089139159109605840==" List-Id: --===============3089139159109605840== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Thank you Valters for the patch :) > On 13 Apr 2021, at 16:38, Peter M=C3=BCller wr= ote: >=20 > Hello Valters, >=20 > thanks for your patch. >=20 > Indeed, the historical changelog of libloc currently contains - um - inform= ation in a > non-optimal fashion. I guess this was due to the lack of time back then, an= d nobody of > us had good experience with packaging stuff for Debian. Thanks for improvin= g this. >=20 > Eventually, we hoped libloc would be used by other distributions as well, s= ince a decent > part of the open source community is facing license trouble after MaxMind c= hanged their > terms and conditions. I remember Michael having a discussion with some memb= ers of the > Debian development team, but my memories fail me when it comes to it's resu= lts. You wanted to reach out to them to find out what it takes to get our package = into Debian :) > Therefore, I am not sure if libloc is ready in a way we would move from "UN= RELEASED" to > "unstable". On the one hand, it is used in production for IPFire since a wh= ile, on the > other hand, nobody else is using the libloc _code_ as such - at least no on= e I am aware of. libloc is stable. We should technically give it the 1.0 version tag soon. However, the Debian package might have some issues, but I do not see that as = a reason that we mark it as =E2=80=9Cplease stay away and use something else= =E2=80=9D. That would send the wrong signal about libloc. I cannot disclose any other users of libloc apart from those that I have alre= ady shared publicly, but we have plenty of downloads of the library so I assu= me that there are some silent users out there :) We should work more on making people aware that there now is an alternative t= o other products available which is truly free software. -Michael > @Michael: What do you think? >=20 > Thanks, and best regards, > Peter M=C3=BCller >=20 >=20 >> Rewriting history is generally considered a "not-so-good" thing, >> however here the historical data does not align with best practises >> and therefore it is beneficial to provide a better example going >> forward. >>=20 >> There is only one initial release. Everything following that should >> list some kind of release notes or changelog, or at the very least >> just say something along the lines of "New version" rather than >> "Initial release". >>=20 >> In this commit, the Git history is used for this task, >> filtering out "Makefile" changes as to retain only changes >> that are visible to users, excluding building tooling. >>=20 >> For Debian packages, upon release, the target distribution should be >> updated to "unstable" (or "experimental" if preferred for any reason) >> when a release is finalized. During development, an invalid >> distribution name is expected to be there for tracking unreleased >> changes. That is why "UNRELEASED" is the standard way of specifying >> ongoing development, being an invalid distribution name itself. >>=20 >> The "(Closes: #XXXXXX)" tag is intended for linking to Debian bug >> tracker, such as linking to the initial Intent to Package ticket, >> or later update/bugfix tickets. There does not appear to be a bug >> tracker in use for this task here, and the XXXXXX bug ticket number >> does not take you anywhere. It's therefore better to just remove it. >> --- >> debian/changelog | 15 +++++++++++---- >> 1 file changed, 11 insertions(+), 4 deletions(-) >>=20 >> diff --git a/debian/changelog b/debian/changelog >> index e0be397..e58c0ca 100644 >> --- a/debian/changelog >> +++ b/debian/changelog >> @@ -1,11 +1,18 @@ >> -libloc (0.9.6-1) UNRELEASED; urgency=3Dmedium >> +libloc (0.9.6-1) unstable; urgency=3Dmedium >>=20 >> - * Initial release. (Closes: #XXXXXX) >> + * location-importer.in: skip networks with unknown country codes >> + * location-importer.in: process unaligned IP ranges in RIR data files >> + correctly >> + * database: Free mmapped countries section >> + * location-importer.in: reduce log noise for unusable networks >> + * location-importer.in: delete 6to4 IPv6 space as well >> + * location-importer.in: fix typo >> + * location: Fix list-networks-by-as >>=20 >> -- Michael Tremer Wed, 31 Mar 2021 14:06:0= 0 +0100 >>=20 >> -libloc (0.9.5-1) UNRELEASED; urgency=3Dmedium >> +libloc (0.9.5-1) unstable; urgency=3Dmedium >>=20 >> - * Initial release. (Closes: #XXXXXX) >> + * Initial release. >>=20 >> -- Stefan Schantl Sun, 27 Oct 2019 18:55:4= 4 +0100 >>=20 --===============3089139159109605840==--