From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject:
 Re: [PATCH] location-importer.in: reduce log noise for unusable networks
Date: Mon, 25 Jan 2021 21:32:08 +0000
Message-ID: <88EE26D4-CD0C-4D8F-A414-9DC43ED6F3D9@ipfire.org>
In-Reply-To: <42bc8670-24ec-e10f-fce8-2a1452d26420@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8937240343820081398=="
List-Id: <location.lists.ipfire.org>

--===============8937240343820081398==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Thank you again.

This won=E2=80=99t be rolled out, yet, because I would need to build new Debi=
an packages for it.

Since we do not have many changes since the last tag, I wouldn=E2=80=99t do t=
his yet. Agreed?

-Michael

> On 16 Jan 2021, at 18:09, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> These are nothing to worry about, which is why debug log facility is
> more suitable here than informational or warning.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> src/python/location-importer.in | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/src/python/location-importer.in b/src/python/location-importer=
.in
> index a4be445..c5ebb54 100644
> --- a/src/python/location-importer.in
> +++ b/src/python/location-importer.in
> @@ -494,12 +494,12 @@ class CLI(object):
> 			return False
>=20
> 		if not network.is_global:
> -			log.warning("Skipping non-globally routable network: %s" % network)
> +			log.debug("Skipping non-globally routable network: %s" % network)
> 			return False
>=20
> 		if network.version =3D=3D 4:
> 			if network.prefixlen < 7:
> -				log.warning("Skipping too big IP chunk: %s" % network)
> +				log.debug("Skipping too big IP chunk: %s" % network)
> 				return False
>=20
> 			if network.prefixlen > 24:
> @@ -507,12 +507,12 @@ class CLI(object):
> 				return False
>=20
> 			if str(network.network_address) =3D=3D "0.0.0.0":
> -				log.warning("Skipping network based on 0.0.0.0: %s" % network)
> +				log.debug("Skipping network based on 0.0.0.0: %s" % network)
> 				return False
>=20
> 		elif network.version =3D=3D 6:
> 			if network.prefixlen < 10:
> -				log.warning("Skipping too big IP chunk: %s" % network)
> +				log.debug("Skipping too big IP chunk: %s" % network)
> 				return False
>=20
> 			if network.prefixlen > 48:
> @@ -520,7 +520,7 @@ class CLI(object):
> 				return False
>=20
> 			if str(network.network_address) =3D=3D "::":
> -				log.warning("Skipping network based on '::': %s" % network)
> +				log.debug("Skipping network based on '::': %s" % network)
> 				return False
>=20
> 		else:
> @@ -587,7 +587,7 @@ class CLI(object):
> 			# not managed by that specific RIR...
> 			if key =3D=3D "netname":
> 				if re.match(r"(ERX-NETBLOCK|(AFRINIC|ARIN|LACNIC|RIPE)-CIDR-BLOCK|IANA-=
NETBLOCK-\d{1,3}|NON-RIPE-NCC-MANAGED-ADDRESS-BLOCK)", val.strip()):
> -					log.warning("Skipping record indicating historic/orphaned data: %s" %=
 val.strip())
> +					log.debug("Skipping record indicating historic/orphaned data: %s" % v=
al.strip())
> 					return
>=20
> 			if key =3D=3D "inetnum":
> --=20
> 2.26.2


--===============8937240343820081398==--