From: Gisle Vanem <gisle.vanem@gmail.com>
To: location@lists.ipfire.org
Subject: Re: [PATCH] location.in: fix search_networks() function call
Date: Tue, 18 May 2021 13:04:37 +0200 [thread overview]
Message-ID: <92b43bc6-c481-71d2-40d1-9f993ead35eb@gmail.com> (raw)
In-Reply-To: <F94D19EB-EF1C-48EE-A924-EB8D0F2C19D5@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
Michael Tremer wrote:
> Thanks. Merged.
>
>> On 16 May 2021, at 21:35, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Fixes: #12617
>>
>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>> ---
>> src/python/location.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/python/location.in b/src/python/location.in
>> index ad2ccf5..e02b4e8 100644
>> --- a/src/python/location.in
>> +++ b/src/python/location.in
>> @@ -506,7 +506,7 @@ class CLI(object):
>> f = writer(sys.stdout, prefix=country_code)
>>
>> # Print all matching networks
>> - for n in db.search_networks(country_code=country_code, family=ns.family):
>> + for n in db.search_networks(country_codes=[country_code], family=ns.family):
>> f.write(n)
High time. I reported this already 1 April:
https://lists.ipfire.org/pipermail/location/2021-April/000263.html
--
--gv
next prev parent reply other threads:[~2021-05-18 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 20:35 Peter Müller
2021-05-18 10:31 ` Michael Tremer
2021-05-18 11:04 ` Gisle Vanem [this message]
2021-05-18 11:06 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92b43bc6-c481-71d2-40d1-9f993ead35eb@gmail.com \
--to=gisle.vanem@gmail.com \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox