Re: [PATCH] location.in: fix search_networks() function call

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

Hello,

Thank you for that. It would be even better if you would follow the guidelines here, so that the patch can be merged into the repository easily: https://wiki.ipfire.org/devel/submit-patches

Best,
-Michael

> On 18 May 2021, at 12:04, Gisle Vanem <gisle.vanem(a)gmail.com> wrote:
> 
> Michael Tremer wrote:
> 
>> Thanks. Merged.
>>> On 16 May 2021, at 21:35, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>> 
>>> Fixes: #12617
>>> 
>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>> ---
>>> src/python/location.in | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/src/python/location.in b/src/python/location.in
>>> index ad2ccf5..e02b4e8 100644
>>> --- a/src/python/location.in
>>> +++ b/src/python/location.in
>>> @@ -506,7 +506,7 @@ class CLI(object):
>>> 			f = writer(sys.stdout, prefix=country_code)
>>> 
>>> 			# Print all matching networks
>>> -			for n in db.search_networks(country_code=country_code, family=ns.family):
>>> +			for n in db.search_networks(country_codes=[country_code], family=ns.family):
>>> 				f.write(n)
> 
> High time. I reported this already 1 April:
>  https://lists.ipfire.org/pipermail/location/2021-April/000263.html
> 
> -- 
> --gv