From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] location.in: fix search_networks() function call
Date: Tue, 18 May 2021 12:06:04 +0100
Message-ID: <9E377429-71C5-43BA-98B1-337AA5348BAF@ipfire.org>
In-Reply-To: <92b43bc6-c481-71d2-40d1-9f993ead35eb@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4769148211913997533=="
List-Id: <location.lists.ipfire.org>

--===============4769148211913997533==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Thank you for that. It would be even better if you would follow the guideline=
s here, so that the patch can be merged into the repository easily: https://w=
iki.ipfire.org/devel/submit-patches

Best,
-Michael

> On 18 May 2021, at 12:04, Gisle Vanem <gisle.vanem(a)gmail.com> wrote:
>=20
> Michael Tremer wrote:
>=20
>> Thanks. Merged.
>>> On 16 May 2021, at 21:35, Peter M=C3=BCller <peter.mueller(a)ipfire.org> =
wrote:
>>>=20
>>> Fixes: #12617
>>>=20
>>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>> ---
>>> src/python/location.in | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>=20
>>> diff --git a/src/python/location.in b/src/python/location.in
>>> index ad2ccf5..e02b4e8 100644
>>> --- a/src/python/location.in
>>> +++ b/src/python/location.in
>>> @@ -506,7 +506,7 @@ class CLI(object):
>>> 			f =3D writer(sys.stdout, prefix=3Dcountry_code)
>>>=20
>>> 			# Print all matching networks
>>> -			for n in db.search_networks(country_code=3Dcountry_code, family=3Dns.=
family):
>>> +			for n in db.search_networks(country_codes=3D[country_code], family=3D=
ns.family):
>>> 				f.write(n)
>=20
> High time. I reported this already 1 April:
>  https://lists.ipfire.org/pipermail/location/2021-April/000263.html
>=20
> --=20
> --gv


--===============4769148211913997533==--