From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: location@lists.ipfire.org Subject: Re: Segfault on d5ff39d "tree: Actually delete any deleted nodes" Date: Tue, 18 Jul 2023 09:29:03 +0100 Message-ID: <9E5109AB-7D8F-4C01-BD3E-166F50CAB6CC@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1075354469875761565==" List-Id: --===============1075354469875761565== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Valters, > On 17 Jul 2023, at 20:15, Valters Jansons wrot= e: >=20 > On Mon, Jul 17, 2023 at 10:09=E2=80=AFPM Michael Tremer > wrote: >> Thanks for reviewing my changes. This was indeed a thing that I did observ= e as well and fixed it right here: >>=20 >> https://git.ipfire.org/?p=3Dlocation/libloc.git;a=3Dcommitdiff;h=3D0e8949= 66750e89d1b83c6ad90f37945d4d349118 >>=20 >> The root node got deleted and lots of the code just relied on it being the= re. Especially when the tree was empty. >=20 > I suspected you would already be aware of the expectations that were > being broken, so wanted to highlight it. Shame on me for not > double-checking whether you had already resolved it before sending the > message! No, I like it when code is double-checked. I did notice myself but after I pushed my first set of changes. I knew there = was some work left to do, but deleting the root node was something I thought = I had covered when I did not. So, please keep the feedback coming. It will help us all to have a better ver= sion of libloc. Best, -Michael > Once again: thank you for the changes! >=20 > -Valters --===============1075354469875761565==--