From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: location@lists.ipfire.org Subject: Re: [PATCH] location-importer.in: Braindead me accidentally forgot a "break" statement Date: Mon, 09 Aug 2021 11:06:41 +0200 Message-ID: In-Reply-To: <881acb1f-a618-bd5c-2a78-0d869122c30a@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6125233753933532719==" List-Id: --===============6125233753933532719== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Are you sure you don=E2=80=99t want this to be =E2=80=9Ccontinue=E2=80=9D? > On 8 Aug 2021, at 23:31, Peter M=C3=BCller wro= te: >=20 > This one apparently went down the drain between these two patches: > - https://patchwork.ipfire.org/project/location/patch/20210522125758.28770-= 1-peter.mueller(a)ipfire.org/ > - https://patchwork.ipfire.org/project/location/patch/aefd1904-4b38-f5cf-ab= 1d-9d69636cf914(a)ipfire.org/ >=20 > Due to other safeguards, the current damage in production is limited to: >=20 > location=3D# SELECT * FROM networks WHERE country =3D 'ZZ'; > network | country | original_countries | source > --------------------+---------+--------------------+-------- > 130.195.64.0/19 | ZZ | {ZZ} | APNIC > 130.195.96.0/19 | ZZ | {ZZ} | APNIC > 122.252.24.0/21 | ZZ | {ZZ} | APNIC > 2406:840:10::/48 | ZZ | {ZZ} | APNIC > 2406:840:fd0f::/48 | ZZ | {ZZ} | APNIC > (5 rows) >=20 > Fixes: #12673 >=20 > Signed-off-by: Peter M=C3=BCller > --- > src/python/location-importer.in | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/src/python/location-importer.in b/src/python/location-importer= .in > index bec0b62..da058d3 100644 > --- a/src/python/location-importer.in > +++ b/src/python/location-importer.in > @@ -702,6 +702,7 @@ class CLI(object): > if validcountries and invalidcountries: > log.warning("Skipping network with bogus countr(y|ies) %s (original co= untries: %s): %s" % \ > (invalidcountries, inetnum.get("country"), inetnum.get("inet6num") or= inetnum.get("inetnum"))) > + break >=20 > # Everything is fine here, run INSERT statement... > self.db.execute("INSERT INTO _rirdata(network, country, original_countr= ies, source) \ > --=20 > 2.26.2 --===============6125233753933532719==--