From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: [PATCH] Makefile: Build debian packages in own directory.
Date: Wed, 11 Dec 2019 16:03:36 +0000 [thread overview]
Message-ID: <C70DB07B-1E58-4EBF-871C-B4A9DADFE01E@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
Hey,
I can get behind this patch although it is quite ugly.
The directory is left after the build has completed and should at least be included in .gitignore as well as being removed on make clean.
Can you edit the patch accordingly?
-Michael
> On 11 Dec 2019, at 15:49, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>
> This helps to keep a much cleaner environment.
>
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> Makefile.am | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 1b9d90e..bf1dde1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -421,4 +421,8 @@ $(DEBIAN_TARBALL_NAME): dist
>
> .PHONY: debian
> debian: $(DEBIAN_TARBALL_NAME)
> - debuild -i -us -uc -b
> + mkdir -pv debian-build/$(PACKAGE_NAME)-$(PACKAGE_VERSION)/debian
> + cp -avf $(DEBIAN_TARBALL_NAME) debian-build
> + cp -avf debian/* debian-build/$(PACKAGE_NAME)-$(PACKAGE_VERSION)/debian
> + cd debian-build && tar -xvf $(DEBIAN_TARBALL_NAME)
> + cd debian-build/$(PACKAGE_NAME)-$(PACKAGE_VERSION) && debuild -us -uc
> --
> 2.20.1
next reply other threads:[~2019-12-11 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 16:03 Michael Tremer [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-11 15:49 Stefan Schantl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C70DB07B-1E58-4EBF-871C-B4A9DADFE01E@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox