From: Valters Jansons <valter.jansons@gmail.com>
To: location@lists.ipfire.org
Subject: Re: [PATCH v2] po: Update translations
Date: Thu, 15 Apr 2021 14:52:22 +0300 [thread overview]
Message-ID: <CA+sCei0i2386jjmLJszr3KiWWZ-e5y5D+Oks52MkUjxoizQKqQ@mail.gmail.com> (raw)
In-Reply-To: <78FE3E0F-3583-4F44-9ACC-03C9371A4923@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Thu, Apr 15, 2021 at 1:58 PM Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> After running those commands I see the following diff which almost entirely reverts all changes in your patch:
Strange -- I wonder where the .py file comes from for you.
> What we would need is to have the command that generates POTFILES.in a mechanism that reads .gitignore and filters out what we do not want (in this case __init__.py).
>
> Does that sound like it makes sense?
Yes. I sent in a v3 patch which uses git-check-ignore for this
purpose. I would really like to avoid working with the .gitignore
files directly for the sake of avoiding complex loops with the various
.gitignore files that could live in all kinds of subdirectories, along
with managing exclusions that are valid in .gitignore.
--Valters
prev parent reply other threads:[~2021-04-15 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 12:02 Valters Jansons
2021-04-14 15:20 ` Michael Tremer
2021-04-14 15:51 ` Valters Jansons
2021-04-15 10:58 ` Michael Tremer
2021-04-15 11:52 ` Valters Jansons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+sCei0i2386jjmLJszr3KiWWZ-e5y5D+Oks52MkUjxoizQKqQ@mail.gmail.com \
--to=valter.jansons@gmail.com \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox