From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valters Jansons To: location@lists.ipfire.org Subject: Re: [PATCH v2] po: Update translations Date: Thu, 15 Apr 2021 14:52:22 +0300 Message-ID: In-Reply-To: <78FE3E0F-3583-4F44-9ACC-03C9371A4923@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9200881381062138570==" List-Id: --===============9200881381062138570== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 15, 2021 at 1:58 PM Michael Tremer wrote: > After running those commands I see the following diff which almost entirely= reverts all changes in your patch: Strange -- I wonder where the .py file comes from for you. > What we would need is to have the command that generates POTFILES.in a mech= anism that reads .gitignore and filters out what we do not want (in this case= __init__.py). > > Does that sound like it makes sense? Yes. I sent in a v3 patch which uses git-check-ignore for this purpose. I would really like to avoid working with the .gitignore files directly for the sake of avoiding complex loops with the various .gitignore files that could live in all kinds of subdirectories, along with managing exclusions that are valid in .gitignore. --Valters --===============9200881381062138570==--