public inbox for location@lists.ipfire.org
 help / color / mirror / Atom feed
From: Valters Jansons <valter.jansons@gmail.com>
To: location@lists.ipfire.org
Subject: Re: [PATCH] debian: Add intltoolize to dh_auto_configure
Date: Mon, 12 Apr 2021 15:50:02 +0300	[thread overview]
Message-ID: <CA+sCei1Gyn8sjt2jLPkw_-ZNMDhyzCjvy4MGWR-HyHXY5O8AnQ@mail.gmail.com> (raw)
In-Reply-To: <4F3D1034-42F2-4FA4-9DD5-F20C553BC088@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Wed, Apr 7, 2021 at 6:08 PM Michael Tremer <michael.tremer(a)ipfire.org> wrote:
> It didn’t apply because all tabs were replaced by spaces in this email. I took care of this manually and pushed it into the master branch.

Sorry - must have been copy-paste from my terminal that went wrong, as
I was grabbing the patch content and pasting it by hand. Thank you for
dealing with this.

> Do you have any more experience with the Debian build system? We kind of put this together without a lot of background knowledge and have a couple of (probably minor) things that could need fixing. Are you able to help?

I have some experience poking around with builds. Initial look at
highlights a missing changelog, a debhelper compatibility level that
could be updated and some apparent auto-test workflow issues, but I
have not had the ability to dig deeper if that's something on my local
system.

Is there something in particular you would be looking for?

-Valters

  reply	other threads:[~2021-04-12 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 11:13 Valters Jansons
2021-04-07 15:08 ` Michael Tremer
2021-04-12 12:50   ` Valters Jansons [this message]
2021-04-13 18:53     ` Michael Tremer
2021-04-20  9:21       ` Valters Jansons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+sCei1Gyn8sjt2jLPkw_-ZNMDhyzCjvy4MGWR-HyHXY5O8AnQ@mail.gmail.com \
    --to=valter.jansons@gmail.com \
    --cc=location@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox