From: Valters Jansons <valter.jansons@gmail.com>
To: location@lists.ipfire.org
Subject: Re: Segfault on d5ff39d "tree: Actually delete any deleted nodes"
Date: Mon, 17 Jul 2023 22:15:57 +0300 [thread overview]
Message-ID: <CA+sCei2ZBEsnoJen0C-7Cy==m-Z92FCdhXrvJ0C16gwkhf-aiw@mail.gmail.com> (raw)
In-Reply-To: <35C9DB4A-BAC6-4A2F-BEC5-B41A8ABE7CB3@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Mon, Jul 17, 2023 at 10:09 PM Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> Thanks for reviewing my changes. This was indeed a thing that I did observe as well and fixed it right here:
>
> https://git.ipfire.org/?p=location/libloc.git;a=commitdiff;h=0e894966750e89d1b83c6ad90f37945d4d349118
>
> The root node got deleted and lots of the code just relied on it being there. Especially when the tree was empty.
I suspected you would already be aware of the expectations that were
being broken, so wanted to highlight it. Shame on me for not
double-checking whether you had already resolved it before sending the
message!
Once again: thank you for the changes!
-Valters
next prev parent reply other threads:[~2023-07-17 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 18:35 Valters Jansons
2023-07-17 19:09 ` Michael Tremer
2023-07-17 19:15 ` Valters Jansons [this message]
2023-07-18 8:29 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+sCei2ZBEsnoJen0C-7Cy==m-Z92FCdhXrvJ0C16gwkhf-aiw@mail.gmail.com' \
--to=valter.jansons@gmail.com \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox