From mboxrd@z Thu Jan  1 00:00:00 1970
From: Valters Jansons <valter.jansons@gmail.com>
To: location@lists.ipfire.org
Subject: Re: Segfault on d5ff39d "tree: Actually delete any deleted nodes"
Date: Mon, 17 Jul 2023 22:15:57 +0300
Message-ID:
 <CA+sCei2ZBEsnoJen0C-7Cy==m-Z92FCdhXrvJ0C16gwkhf-aiw@mail.gmail.com>
In-Reply-To: <35C9DB4A-BAC6-4A2F-BEC5-B41A8ABE7CB3@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1728779856087401288=="
List-Id: <location.lists.ipfire.org>

--===============1728779856087401288==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 17, 2023 at 10:09=E2=80=AFPM Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> Thanks for reviewing my changes. This was indeed a thing that I did observe=
 as well and fixed it right here:
>
>   https://git.ipfire.org/?p=3Dlocation/libloc.git;a=3Dcommitdiff;h=3D0e8949=
66750e89d1b83c6ad90f37945d4d349118
>
> The root node got deleted and lots of the code just relied on it being ther=
e. Especially when the tree was empty.

I suspected you would already be aware of the expectations that were
being broken, so wanted to highlight it. Shame on me for not
double-checking whether you had already resolved it before sending the
message!

Once again: thank you for the changes!

-Valters

--===============1728779856087401288==--