public inbox for location@lists.ipfire.org
 help / color / mirror / Atom feed
From: Valters Jansons <valter.jansons@gmail.com>
To: location@lists.ipfire.org
Subject: Re: [PATCH 6/8] debian: Drop unintended files from location-python
Date: Mon, 19 Apr 2021 16:56:51 +0300	[thread overview]
Message-ID: <CA+sCei3g9zQQ=SAHip=V0VGx_wYzNbR+8jAFn_FCm8kfM++_Ow@mail.gmail.com> (raw)
In-Reply-To: <E8A7B23E-C134-4086-BAB3-0181F198C601@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On Mon, Apr 19, 2021 at 4:14 PM Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> > The only reason the file is there is that it gets built inside the
> > source directory, which gets copied entirely to location-python package
> > as-is. Considering the situation, this commit ensures the .la files is
> > not packaged by deleting it from the package files subdirectory.
> >
> > location-importer package pulls in two Python (.py) files from the
> > source directory. These files should not be included in the
> > location-python package as a result.
>
> And how do they go there when they are just being deleted here?

dh_install copies files to separate subdirectories, from which
packages are constructed.

d/location-python.install specifies:
usr/lib/python3*/site-packages

d/location-importer.install specifies:
usr/lib/python3*/site-packages/location/database.py
usr/lib/python3*/site-packages/location/importer.py

As a result, those two particular .py files end up in both the
location-python and location-importer package subtrees. After
dh_install, before the next stage of packaging, we can get rid of the
two files from the location-python directory.

--Valters

  reply	other threads:[~2021-04-19 13:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 13:06 [PATCH 0/8] debian: Mitigate bulk of Lintian issues Valters Jansons
2021-04-16 13:06 ` [PATCH 1/8] debian: Add all temporary files to Gitignore Valters Jansons
2021-04-19 13:10   ` Michael Tremer
2021-04-19 13:48     ` Valters Jansons
2021-04-16 13:06 ` [PATCH 2/8] debian: Move libloc1 to 'libs' section Valters Jansons
2021-04-16 13:06 ` [PATCH 3/8] debian: Set 'Multi-Arch: foreign' hint for Python Valters Jansons
2021-04-16 13:06 ` [PATCH 4/8] debian: Update copyright format link to use HTTPS Valters Jansons
2021-04-16 13:06 ` [PATCH 5/8] debian: Add examples/python/ to documentation Valters Jansons
2021-04-16 13:06 ` [PATCH 6/8] debian: Drop unintended files from location-python Valters Jansons
2021-04-19 13:14   ` Michael Tremer
2021-04-19 13:56     ` Valters Jansons [this message]
2021-04-16 13:06 ` [PATCH 7/8] debian: Add watch configuration for uscan Valters Jansons
2021-04-19 13:15   ` Michael Tremer
2021-04-16 13:06 ` [PATCH 8/8] systemd: Add Documentation= to location-update Valters Jansons
2021-04-19 13:10 ` [PATCH 0/8] debian: Mitigate bulk of Lintian issues Michael Tremer
2021-04-27  9:28   ` Valters Jansons
2021-05-04 14:50     ` Michael Tremer
2021-05-04 18:40       ` Valters Jansons
2021-05-06 15:12         ` Michael Tremer
2021-05-06 17:37           ` Valters Jansons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+sCei3g9zQQ=SAHip=V0VGx_wYzNbR+8jAFn_FCm8kfM++_Ow@mail.gmail.com' \
    --to=valter.jansons@gmail.com \
    --cc=location@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox