From: Jordan Savoca <jsavoca@posteo.net>
To: location@lists.ipfire.org
Subject: Re: Reduced AS/route visibility
Date: Fri, 22 Mar 2024 16:21:01 +0000 [thread overview]
Message-ID: <D00EZXMXL776.3B67CCVYM7C83@posteo.net> (raw)
In-Reply-To: <6235F8A4-DFDF-42C6-B59F-836BAE19996F@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]
On Fri Mar 22, 2024 at 9:09 AM MST, Michael Tremer wrote:
> Hello Jordan,
>
> Thank you very much for your email. This has really helped me.
>
> Recently I have been rolling out a lot of changes that massively improve the database. I have not been 100% confident that all problems have been solved, however I did not have and indication that things went wrong.
>
> One of the changes was a deduplication algorithm that is supposed to remove any subnets from the database we don’t need. That works well.
>
> The second change is to merge neighbouring subnets (e.g. 10.0.0.0/24 and 10.0.1.0/24 could be stored as 10.0.0.0/23). That would save a lot of space, too. That algorithm relied on a function to count the bit length of an IP address (i.e. the minimum number of bits I need to represent a certain IP address). That function was total garbage. No idea how that didn’t cause bigger damage.
>
> The fix is now here:
>
> https://git.ipfire.org/?p=location/libloc.git;a=commitdiff;h=edbf280e6e043eaf38d4526e421cd68fcf7bc5c0
>
> I have published an updated version of the database with the fix:
>
> https://git.ipfire.org/?p=location/location-database.git;a=commitdiff;h=16e9065d8017548999e4c4817206214613cd1e02
>
> We now have data for the networks that you have listed (as expected):
Awesome, thank you so much for the quick turnaround on a fix, much
appreciated! :)
I hope you have a great weekend!
--
Jordan
next prev parent reply other threads:[~2024-03-22 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 4:03 Jordan Savoca
2024-03-22 16:09 ` Michael Tremer
2024-03-22 16:21 ` Jordan Savoca [this message]
2024-03-22 16:27 ` Jordan Savoca
2024-03-22 16:34 ` Michael Tremer
2024-03-22 16:54 ` Jordan Savoca
2024-03-22 16:55 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D00EZXMXL776.3B67CCVYM7C83@posteo.net \
--to=jsavoca@posteo.net \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox