From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Savoca To: location@lists.ipfire.org Subject: Re: Reduced AS/route visibility Date: Fri, 22 Mar 2024 16:21:01 +0000 Message-ID: In-Reply-To: <6235F8A4-DFDF-42C6-B59F-836BAE19996F@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0302116127343133876==" List-Id: --===============0302116127343133876== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri Mar 22, 2024 at 9:09 AM MST, Michael Tremer wrote: > Hello Jordan, > > Thank you very much for your email. This has really helped me. > > Recently I have been rolling out a lot of changes that massively improve th= e database. I have not been 100% confident that all problems have been solved= , however I did not have and indication that things went wrong. > > One of the changes was a deduplication algorithm that is supposed to remove= any subnets from the database we don=E2=80=99t need. That works well. > > The second change is to merge neighbouring subnets (e.g. 10.0.0.0/24 and 10= .0.1.0/24 could be stored as 10.0.0.0/23). That would save a lot of space, to= o. That algorithm relied on a function to count the bit length of an IP addre= ss (i.e. the minimum number of bits I need to represent a certain IP address)= . That function was total garbage. No idea how that didn=E2=80=99t cause bigg= er damage. > > The fix is now here: > > https://git.ipfire.org/?p=3Dlocation/libloc.git;a=3Dcommitdiff;h=3Dedbf28= 0e6e043eaf38d4526e421cd68fcf7bc5c0 > > I have published an updated version of the database with the fix: > > https://git.ipfire.org/?p=3Dlocation/location-database.git;a=3Dcommitdiff= ;h=3D16e9065d8017548999e4c4817206214613cd1e02 > > We now have data for the networks that you have listed (as expected): Awesome, thank you so much for the quick turnaround on a fix, much appreciated! :) I hope you have a great weekend! -- Jordan --===============0302116127343133876==--