From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: mem-map leak in loc_database_free()
Date: Mon, 22 Mar 2021 11:44:34 +0000
Message-ID: <D8BC0E4A-0A27-4AAC-9A4C-0154A2AAD2B2@ipfire.org>
In-Reply-To: <45bfe380-44a1-5e0a-2e8f-d8fb7bf8e8fa@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8721190269852574197=="
List-Id: <location.lists.ipfire.org>

--===============8721190269852574197==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Gisle,

Thank you for reporting this problem.

Copying files under Linux works even when they are left open like this.

However, I merged your patch.

-Michael

> On 21 Mar 2021, at 16:35, Gisle Vanem <gisle.vanem(a)gmail.com> wrote:
>=20
> Hello list.
>=20
> In my Windows program I use the 'libloc' library
> and the compressed 'location.db.xz' file. I also have
> some functions to download, decompress to a temp-file.
> Then finally using 'CopyFile()' to update to the final
> .db-file.
>=20
> But my problem was that 'CopyFile()' failed with error
> 'ERROR_USER_MAPPED_FILE' since some regions to the file
> was not closed.
>=20
> I saw that 'libloc' does 5 calls to 'mmap()' but only
> 4 calls to 'munmap()' in 'loc_database_free()'; the freeing
> of 'db->countries_v1' is missing.
>=20
> So with this patch my program works fine:
>=20
> --- a/database.c 2020-12-03 15:04:38
> +++ b/database.c 2021-03-21 17:21:04
>=20
> @@ -446,6 +446,13 @@
>                        ERROR(db->ctx, "Could not unmap network nodes sectio=
n: %s\n", strerror(errno));
>        }
>=20
> +       // Remove mapped countries nodes section
> +       if (db->countries_v1) {
> +               r =3D munmap(db->countries_v1, db->countries_count * sizeof=
(*db->countries_v1));
> +               if (r)
> +                       ERROR(db->ctx, "Could not unmap countries nodes sec=
tion: %s\n", strerror(errno));
> +       }
> +
>        if (db->pool)
>                loc_stringpool_unref(db->pool);
> ---------
>=20
> Not sure how 'libloc' could work w/o this on Linux.
> What does a 'cp /tmp/location.db location-in-use.db'
> say when running one of the test programs in parallel?
>=20
> --=20
> --gv


--===============8721190269852574197==--