From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Subject: Re: Warning in '__loc_network_tree_count()'
Date: Sat, 04 Mar 2023 11:03:49 +0000 [thread overview]
Message-ID: <F4EA93E7-CC0F-49A6-B84D-2A12373A9DB0@ipfire.org> (raw)
In-Reply-To: <7845ed2c-76c8-df33-7f8a-2bccd8d10c6e@online.no>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Hello,
> On 4 Mar 2023, at 11:00, Gisle Vanem <gvanem(a)online.no> wrote:
>
> Michael Tremer wrote:
>
>>> So shouldn't the function be:
>>>
>>> static int __loc_network_tree_count(struct loc_network* network, void* data) {
>>> size_t* counter = (size_t*)data;
>>>
>>> // Increase the counter for each network
>>> (*counter)++;
>>> return 0;
>> Yes, you are incorrect. I am incrementing the pointer when I wanted to increment the value.
>
> You mean "you are correct"?
>
>> Thank you for helping to improve libloc. How does it run on Windows?
> I doesn't run at all w/o much patching by myself. I've added
> support for it and 'location.db' files in my project Wsock-trace:
> https://github.com/gvanem/wsock-trace
>
> The patched up 'libloc' version:
> https://github.com/gvanem/wsock-trace/tree/master/src/Geo-IP/IPFire/src
Do you intend to upstream those changes at some point (if that is possible)?
>
> --
> --gv
prev parent reply other threads:[~2023-03-04 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 10:44 Gisle Vanem
2023-03-04 10:51 ` Michael Tremer
2023-03-04 11:00 ` Gisle Vanem
2023-03-04 11:03 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F4EA93E7-CC0F-49A6-B84D-2A12373A9DB0@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox