Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Valters Jansons]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Tue, May 11, 2021 at 12:41 PM Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> I have attached the log files of the build on my machine using the build scripts provided with the package.
>
> Hopefully they have what you are looking for.

Regarding the 'no binaries'/empty location-importer package - that
still seems to be a problem with the 0.9.7 release visible on
packages.ipfire.org. They only contain changelog.Debian.gz and
copyright for all architectures.

This doesn't feel like it should be environment specific, as it
invokes a chroot. I am not able to reproduce this (running the
debian/build.sh) on my Ubuntu Focal (20.04) installation, which runs
the buster target, and produces a location-importer package with a
usr/bin/location-importer and other files.

Is the build environment itself up-to-date? Any available updates for
sbuild, or any other tooling on the host by any chance?

Will have to spin up a Debian Buster VM to test this out then. I have
some sneaking suspicion that buster-backports might be beneficial to
enable on the host.

--Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

Hello,

> On 11 Jul 2021, at 18:21, Valters Jansons <valter.jansons(a)gmail.com> wrote:
> 
> On Tue, May 11, 2021 at 12:41 PM Michael Tremer
> <michael.tremer(a)ipfire.org> wrote:
>> I have attached the log files of the build on my machine using the build scripts provided with the package.
>> 
>> Hopefully they have what you are looking for.
> 
> Regarding the 'no binaries'/empty location-importer package - that
> still seems to be a problem with the 0.9.7 release visible on
> packages.ipfire.org. They only contain changelog.Debian.gz and
> copyright for all architectures.

Yes, I can confirm that.

> This doesn't feel like it should be environment specific, as it
> invokes a chroot. I am not able to reproduce this (running the
> debian/build.sh) on my Ubuntu Focal (20.04) installation, which runs
> the buster target, and produces a location-importer package with a
> usr/bin/location-importer and other files.
> 
> Is the build environment itself up-to-date? Any available updates for
> sbuild, or any other tooling on the host by any chance?

I am running “make debian” and I assumed this would always use the latest set of released packages.

> Will have to spin up a Debian Buster VM to test this out then. I have
> some sneaking suspicion that buster-backports might be beneficial to
> enable on the host.

We should virtual environments for all releases and architectures, but please feel free to dig and find what is actually going wrong. I have no clue.

-Michael

> --Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Valters Jansons]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Thu, May 6, 2021 at 6:12 PM Michael Tremer <michael.tremer(a)ipfire.org> wrote:
> All done. I merged them both.

Thank you!

> Did you have time to have a look at the bug that location-importer is not being packaged or is that already fixed?

There are no changes so far that directly modify the packaging
behavior when it comes to what files are being used for the
location-importer package in particular.

I can confirm the problem with location-importer.deb from
https://packages.ipfire.org/location/buster/ by running
`dpkg -c location-importer_0.9.6-1_$ARCH.deb`.
But nothing that pops out right away, causing this.

Would be interesting to see build logs from the server doing the
packaging for this. Maybe they could shed some light.

--Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hello,

All done. I merged them both.

Did you have time to have a look at the bug that location-importer is not being packaged or is that already fixed?

-Michael

> On 4 May 2021, at 19:40, Valters Jansons <valter.jansons(a)gmail.com> wrote:
> 
> On Tue, May 4, 2021 at 5:50 PM Michael Tremer <michael.tremer(a)ipfire.org> wrote:
>> Yes, did you see my emails on those?
> 
> Not sure if my emails got lost along the way to you, but they do
> appear to be listed in Patchwork:
> For 1/8, https://patchwork.ipfire.org/comment/4452/
> For 6/8, https://patchwork.ipfire.org/comment/4453/
> 
> Or is something left unanswered following those?
> 
> --Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Valters Jansons]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Tue, May 4, 2021 at 5:50 PM Michael Tremer <michael.tremer(a)ipfire.org> wrote:
> Yes, did you see my emails on those?

Not sure if my emails got lost along the way to you, but they do
appear to be listed in Patchwork:
For 1/8, https://patchwork.ipfire.org/comment/4452/
For 6/8, https://patchwork.ipfire.org/comment/4453/

Or is something left unanswered following those?

--Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hello,

Yes, did you see my emails on those?

Best,
-Michael

> On 27 Apr 2021, at 10:28, Valters Jansons <valter.jansons(a)gmail.com> wrote:
> 
> On Mon, Apr 19, 2021 at 4:10 PM Michael Tremer
> <michael.tremer(a)ipfire.org> wrote:
>> I have a could of questions about some of them and I will merge some others straight away.
> 
> Is there anything else left unanswered, or causing doubt with [1/8]
> "Add all temporary files to Gitignore" and [6/8] "Drop unintended
> files from location-python" which have not been merged yet?
> 
> --Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Valters Jansons]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Mon, Apr 19, 2021 at 4:10 PM Michael Tremer
<michael.tremer(a)ipfire.org> wrote:
> I have a could of questions about some of them and I will merge some others straight away.

Is there anything else left unanswered, or causing doubt with [1/8]
"Add all temporary files to Gitignore" and [6/8] "Drop unintended
files from location-python" which have not been merged yet?

--Valters

Re: [PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Hello Valters,

Thank you for splitting the big patch into many smaller ones.

I have a could of questions about some of them and I will merge some others straight away.

Best,
-Michael

> On 16 Apr 2021, at 14:06, Valters Jansons <valter.jansons(a)gmail.com> wrote:
> 
> This series breaks apart the previously submitted block of
> debian/ changes into individual logical changes, which can
> be individually reviewed and discussed, and approved.
> 
> This series is however missing the change for d/clean and
> d/libloc1.symbols, which are both pending rework as discussed
> in the superseded patch.
> 
> Valters Jansons (8):
>  debian: Add all temporary files to Gitignore
>  debian: Move libloc1 to 'libs' section
>  debian: Set 'Multi-Arch: foreign' hint for Python
>  debian: Update copyright format link to use HTTPS
>  debian: Add examples/python/ to documentation
>  debian: Drop unintended files from location-python
>  debian: Add watch configuration for uscan
>  systemd: Add Documentation= to location-update
> 
> debian/.gitignore                      | 9 +++++----
> debian/control                         | 5 +++--
> debian/copyright                       | 2 +-
> debian/location-python.examples        | 1 +
> debian/rules                           | 8 ++++++++
> debian/watch                           | 3 +++
> src/systemd/location-update.service.in | 1 +
> 7 files changed, 22 insertions(+), 7 deletions(-)
> create mode 100644 debian/location-python.examples
> create mode 100644 debian/watch
> 
> -- 
> 2.31.1
> 

[PATCH 0/8] debian: Mitigate bulk of Lintian issues

[Valters Jansons]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

This series breaks apart the previously submitted block of
debian/ changes into individual logical changes, which can
be individually reviewed and discussed, and approved.

This series is however missing the change for d/clean and
d/libloc1.symbols, which are both pending rework as discussed
in the superseded patch.

Valters Jansons (8):
  debian: Add all temporary files to Gitignore
  debian: Move libloc1 to 'libs' section
  debian: Set 'Multi-Arch: foreign' hint for Python
  debian: Update copyright format link to use HTTPS
  debian: Add examples/python/ to documentation
  debian: Drop unintended files from location-python
  debian: Add watch configuration for uscan
  systemd: Add Documentation= to location-update

 debian/.gitignore                      | 9 +++++----
 debian/control                         | 5 +++--
 debian/copyright                       | 2 +-
 debian/location-python.examples        | 1 +
 debian/rules                           | 8 ++++++++
 debian/watch                           | 3 +++
 src/systemd/location-update.service.in | 1 +
 7 files changed, 22 insertions(+), 7 deletions(-)
 create mode 100644 debian/location-python.examples
 create mode 100644 debian/watch

-- 
2.31.1