From: "Peter Müller" <peter.mueller@ipfire.org>
To: location@lists.ipfire.org
Subject: [PATCH v2 1/3] location-importer.in: avoid violating NOT NULL constraints during JOIN
Date: Sun, 20 Sep 2020 19:19:36 +0000 [thread overview]
Message-ID: <d2919c7d-9712-b4ce-3977-15d2b00f1860@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
src/python/location-importer.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/python/location-importer.in b/src/python/location-importer.in
index f5ae4a9..77952f2 100644
--- a/src/python/location-importer.in
+++ b/src/python/location-importer.in
@@ -360,7 +360,7 @@ class CLI(object):
ON COMMIT DROP;
CREATE UNIQUE INDEX _autnums_number ON _autnums(number);
- CREATE TEMPORARY TABLE _organizations(handle text, name text)
+ CREATE TEMPORARY TABLE _organizations(handle text, name text NOT NULL)
ON COMMIT DROP;
CREATE UNIQUE INDEX _organizations_handle ON _organizations(handle);
""")
@@ -373,7 +373,7 @@ class CLI(object):
self.db.execute("""
INSERT INTO autnums(number, name)
SELECT _autnums.number, _organizations.name FROM _autnums
- LEFT JOIN _organizations ON _autnums.organization = _organizations.handle
+ JOIN _organizations ON _autnums.organization = _organizations.handle
ON CONFLICT (number) DO UPDATE SET name = excluded.name;
""")
--
2.26.2
next reply other threads:[~2020-09-20 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 19:19 Peter Müller [this message]
2020-09-20 19:20 ` [PATCH v2 2/3] importer: Import raw sources for inetnum's again Peter Müller
2020-09-20 19:21 ` [PATCH v2 3/3] importer: Purge any redundant entries Peter Müller
2020-09-24 10:22 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2919c7d-9712-b4ce-3977-15d2b00f1860@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox