From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: location@lists.ipfire.org Subject: Re: [PATCH] debian: Rework historical changelog Date: Tue, 13 Apr 2021 17:38:53 +0200 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6714548621923362685==" List-Id: --===============6714548621923362685== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Valters, thanks for your patch. Indeed, the historical changelog of libloc currently contains - um - informat= ion in a non-optimal fashion. I guess this was due to the lack of time back then, and = nobody of us had good experience with packaging stuff for Debian. Thanks for improving = this. Eventually, we hoped libloc would be used by other distributions as well, sin= ce a decent part of the open source community is facing license trouble after MaxMind cha= nged their terms and conditions. I remember Michael having a discussion with some member= s of the Debian development team, but my memories fail me when it comes to it's result= s. Therefore, I am not sure if libloc is ready in a way we would move from "UNRE= LEASED" to "unstable". On the one hand, it is used in production for IPFire since a whil= e, on the other hand, nobody else is using the libloc _code_ as such - at least no one = I am aware of. @Michael: What do you think? Thanks, and best regards, Peter M=C3=BCller > Rewriting history is generally considered a "not-so-good" thing, > however here the historical data does not align with best practises > and therefore it is beneficial to provide a better example going > forward. >=20 > There is only one initial release. Everything following that should > list some kind of release notes or changelog, or at the very least > just say something along the lines of "New version" rather than > "Initial release". >=20 > In this commit, the Git history is used for this task, > filtering out "Makefile" changes as to retain only changes > that are visible to users, excluding building tooling. >=20 > For Debian packages, upon release, the target distribution should be > updated to "unstable" (or "experimental" if preferred for any reason) > when a release is finalized. During development, an invalid > distribution name is expected to be there for tracking unreleased > changes. That is why "UNRELEASED" is the standard way of specifying > ongoing development, being an invalid distribution name itself. >=20 > The "(Closes: #XXXXXX)" tag is intended for linking to Debian bug > tracker, such as linking to the initial Intent to Package ticket, > or later update/bugfix tickets. There does not appear to be a bug > tracker in use for this task here, and the XXXXXX bug ticket number > does not take you anywhere. It's therefore better to just remove it. > --- > debian/changelog | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) >=20 > diff --git a/debian/changelog b/debian/changelog > index e0be397..e58c0ca 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,11 +1,18 @@ > -libloc (0.9.6-1) UNRELEASED; urgency=3Dmedium > +libloc (0.9.6-1) unstable; urgency=3Dmedium >=20 > - * Initial release. (Closes: #XXXXXX) > + * location-importer.in: skip networks with unknown country codes > + * location-importer.in: process unaligned IP ranges in RIR data files > + correctly > + * database: Free mmapped countries section > + * location-importer.in: reduce log noise for unusable networks > + * location-importer.in: delete 6to4 IPv6 space as well > + * location-importer.in: fix typo > + * location: Fix list-networks-by-as >=20 > -- Michael Tremer Wed, 31 Mar 2021 14:06:0= 0 +0100 >=20 > -libloc (0.9.5-1) UNRELEASED; urgency=3Dmedium > +libloc (0.9.5-1) unstable; urgency=3Dmedium >=20 > - * Initial release. (Closes: #XXXXXX) > + * Initial release. >=20 > -- Stefan Schantl Sun, 27 Oct 2019 18:55:4= 4 +0100 >=20 --===============6714548621923362685==--