From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gisle Vanem <gisle.vanem@gmail.com>
To: location@lists.ipfire.org
Subject: Re: What generates database.db from database.txt?
Date: Tue, 20 Oct 2020 21:14:41 +0200
Message-ID: <f9d416a7-c075-5825-8c42-0908498be5ec@gmail.com>
In-Reply-To: <0A556AF2-9F53-467C-9627-1208A6E20CAA@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7024351441191407151=="
List-Id: <location.lists.ipfire.org>

--===============7024351441191407151==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Michael Tremer wrote:

> Would you be willing to tidy up your code (if required) and submit them on =
here so that we can officially support Windows?

I've put a preliminary version of my patched 'libloc'
in my 'Wsock-trace' project:
   https://github.com/gvanem/wsock-trace/tree/master/src/Geo-IP/IPFire/libloc=
/src

>> Running all the 'test-*' programs, it worked seemingly
>> well. Until I built the Python3 module and played with
>> e.g. 'location dump' and 'verify'. Nothing worked :-(
>=20
> What didn=E2=80=99t work specifically? Reading and writing the database?

'test-database' says:
   Vendor doesn't match: LOCDBXX=E2=98=BA !=3D Test Vendor
and 'test-network':
   Could not look up 2001:db8::

I'm not sure it due to my 'mmap()' function.
But I noted a case where 'loc_stringpool_get()' could
return NULL, this is used in 'strdup()'. Not sure that's
legal everywhere. So I did this patch:

--- a/libloc/src/as.c 2020-10-19 17:35:01
+++ b/libloc/src/as.c 2020-10-20 19:37:19
@@ -90,7 +90,7 @@
  }

  LOC_EXPORT int loc_as_set_name(struct loc_as* as, const char* name) {
-       as->name =3D strdup(name);
+       as->name =3D name ? strdup(name) : strdup("");

         return 0;
  }

> What you will need to import the raw data is location-importer which comes =

> with libloc and a PostgreSQL server.

No! I hoped that 'libloc' would be similar to
IP2Location and/or GeoipCSV that I already support
in my project. Running PostgreSQL is out of the question
for me or any users of 'Wsock-trace'.

> Generating the whole database might take a couple of hours
> depending on how beefy your machine is.

Lacking in Python skills, I cooked up this 'compile-database'
script that takes 2 minutes:
   https://github.com/gvanem/wsock-trace/blob/master/src/Geo-IP/IPFire/databa=
se/compile-database.py

But it remains to see if it works. Or if I'll rewrite it
into a C-program.

--=20
--gv

--===============7024351441191407151==--