From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: network@lists.ipfire.org
Subject:
 Re: [network] [PATCH 3/3] Only call radvd_update if a zone contains	an IPv6.
Date: Wed, 25 Jan 2017 15:37:35 +0100
Message-ID: <1485355055.15495.1.camel@ipfire.org>
In-Reply-To: <20170125134821.15442-3-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1585007971272860748=="
List-Id: <network.lists.ipfire.org>

--===============1585007971272860748==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Please ignore this patch,

it fixes the descibed issue on IPv4 only systems but there is another
issue with IPv6 as well which requires more and deeper work to get this
solved in a right way.

Thanks in advance,

-Stefan
> On systems which lacks any IPv6 configured zone, radvd would be
> started with an empty configuration file and crashes which will
> brick the system startup and results in a frozen system.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  src/functions/functions.routing | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/functions/functions.routing
> b/src/functions/functions.routing
> index c7aac09..4824f34 100644
> --- a/src/functions/functions.routing
> +++ b/src/functions/functions.routing
> @@ -81,7 +81,9 @@ routing_default_update() {
>  		routes=$(echo ${routes})
>  
>  		# Reload radvd configuration
> -		[[ "${proto}" = "ipv6" ]] && radvd_update
> +		if [[ "${proto}" = "ipv6" ]] && db_exists
> "${zone}/ipv6"; then
> +			radvd_update
> +		fi
>  
>  		# Remove all default routes.
>  		if [ -z "${routes}" ]; then

--===============1585007971272860748==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSllpTGd2QUFvSkVFN1hUaFdQazdMZVFFc1AvMUQ4bjRtS25yS09pdVl0NWhQRFdzUzEK
RlRXcnVEaGhFRE9McFB5QTZBRkZQaThySDRHMU5KVElpUEsxRjFIOEoxZEE4WXNBWlVyQjFhOUlm
aWtqNDIxZgpuN0xxZk9lQ2ZMNlQxOVNQWmJMZ2hGZHhNemd6WkRiWkMyc28vNWd3UnhaUEFHVkN2
YmM4Q1haWDg2a3V6SUpuCk5BUWc5YjF1eHZuK005akdRTFFNVmNLd3AwaStTMWpTd01qWW5NTXk1
MFJWa2xQQXZLRklCSHRTbjZ2aGxCdUwKUlFJZ1VwNjc1S0dxYzFBVWJmL3UxOGpnNXBqb2liQTRC
bC90UkQ4YXluSFZJSE5INWhwUnFKT1R2MFZ4MnJSMQpxeEJhRTloVXhWVlY5elI5eUR2UUp2bXZX
ZnZ0dUxjTlUrZjJHN0tHcWdYVFg3ZVZSUnJUeXJxMDBKQXNVUkphCkxpNlFQajZvMXliK29PU2w1
SDVyVTVwdkQ4YndtNHB3VnZtWkd0bVV4bFE5eHlacFREWjltUDZwanhZVHFhSGEKQUtpM3pZYkdZ
Vk5uMzAvVUNURCtySmRpdmdLZHhCc1FEQ21HV0hBZXBUbzd0L1BKN3VzcHYzdW1NL1VhbjhwTwpq
dVJucSsrUCtQczloMkQ1Vnp0VVNsQVM3VWlLZk54RHVkby9GbUZadEEzbUNvc0lHRTF3cVF1ZTZJ
dm5BNVE0ClozenNUUmFWMXJKeURJc3N1TTdDVS9HRGlyQVdYVVRJMTJIc2xKNmdGbVpLQU4wVU0y
ejdpQ3d1R2xBdjYrKzgKL09hVVdydWdKeGw5S2Flc0dZOFpCRDY1QzRscGZ3OEdCOTUzYm14cWFa
T1RmeXZ3bXRLNEVQOUJjMUFKS2g4QgpmY0didVJBUE05em5vK0FHQStmUQo9KzdvcAotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============1585007971272860748==--