Re: [PATCH 5/6] network: add color commands

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Hi,

On Fri, 2017-06-09 at 12:17 +0200, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/network | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/network b/src/network
> index e0d57a0..1bccdea 100644
> --- a/src/network
> +++ b/src/network
> @@ -518,6 +518,9 @@ cli_port() {
>  			edit|create|remove|up|down|status|identify)
>  				port_${action} "${port}" $@
>  				;;
> +			color)
> +				color_cli "port" "${port}" $@
> +			;;
>  			*)
>  				error "Unrecognized argument:
> ${action}"
>  				exit ${EXIT_ERROR}

Indentation of ;; is incorrect.

> @@ -576,6 +579,9 @@ cli_zone() {
>  			config|disable|down|edit|enable|identify|sta
> tus|up)
>  				zone_${action} ${zone} $@
>  				;;
> +			color)
> +				color_cli "zone" "${zone}" $@
> +				;;
>  			*)
>  				error "Unrecognized argument:
> ${action}"
>  				cli_show_man network-zone

Apart from that this is really elegantly solved ;)

-Michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]