From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 5/6] network: add color commands
Date: Wed, 14 Jun 2017 22:10:05 +0100
Message-ID: <1497474605.2416.15.camel@ipfire.org>
In-Reply-To: <1497003452-10190-5-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2816355619936721129=="
List-Id: <network.lists.ipfire.org>

--===============2816355619936721129==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi,

On Fri, 2017-06-09 at 12:17 +0200, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/network | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/network b/src/network
> index e0d57a0..1bccdea 100644
> --- a/src/network
> +++ b/src/network
> @@ -518,6 +518,9 @@ cli_port() {
>  			edit|create|remove|up|down|status|identify)
>  				port_${action} "${port}" $@
>  				;;
> +			color)
> +				color_cli "port" "${port}" $@
> +			;;
>  			*)
>  				error "Unrecognized argument:
> ${action}"
>  				exit ${EXIT_ERROR}

Indentation of ;; is incorrect.

> @@ -576,6 +579,9 @@ cli_zone() {
>  			config|disable|down|edit|enable|identify|sta
> tus|up)
>  				zone_${action} ${zone} $@
>  				;;
> +			color)
> +				color_cli "zone" "${zone}" $@
> +				;;
>  			*)
>  				error "Unrecognized argument:
> ${action}"
>  				cli_show_man network-zone

Apart from that this is really elegantly solved ;)

-Michael

--===============2816355619936721129==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlpRYVl0QUFvSkVJQjU4UDl2a0FrSDArOFAvM0lKYjJhT09zQ3N4TjFseVpBNElIcnEK
UjBLWDFzQmdRbVZxUUFobDNnZU1MS1NTMmxDcGYzZWdyTFp4L3BzdGRGZ2pXdmpmOTdKVnZoYWNT
RHhXWGRKNAp1ZmJBdzdBcHpXUkNiV2JQcnV5VW1kRE1IdWhVVjVsY0NOdXp1K3orbkVZYjUyU1dL
YkpCR2NOYnBSTldJSkppCndDcURwbzhFM1VRVlllRnNxRjJVT0lHSTRHbUpIbmRFMUNqeFJBeXA2
YzdKbXNXTTQ4UVJSd2NpcHYyd2lPT1QKaWpkb1VIRkhYSE1KUStUejE0S2gvdjVZaURrQmd1cTl6
OEZHaklDbjdCU01xdElOcHE4a2orVzA1WGhKZjh0SQp1VDJwRW43UFNEUkhUVXIvYjdrSGhRU1p4
MU1aUEpmV2RHRUlyampzVElnVitITlE3U0hldkhsc3IvNUp3dlBXCnVWQnFJaFhwQzR3N3FHT1Ft
Q1dwbmUrTlQxbk1ybXVmU1pPUERtMTBwTjZ1WW5VU2JRSkt6OE42S1hpY2JIR2QKa2s5Y0VweVBh
RG5uSW84YVA4VG90b0ZNSzRXQjB1QURVbE1Sa0RXMFBsY0o4VDdqUkFTQ2NlZXFRVnU1ejM1QQpo
bGt1bTNicTFaRndta2ZpRFdTNG90M3pkOGROaERsL2U1NmFocG42Q2ZVYVVSWmNyTW12L2hlOFJm
ZzdUeFFpCmVnalVDaWtFWmZwM1RSQUx0ZHRDMnV4cWxjK09qY0VXaEJqczlJQkVwdHp1ZDRFOU80
VWJsYlNNZ2ltd3VpU1YKbWJtdzBkeHNFSUJVSi9QY3ZqYXJQMjVIMnFqWGFDNXIyMVkxWkNteEpq
cWFLMlhGZStBUE9IQ1lRZU5QL1c1KwpKTGNWSUxjUk1PUHUzbkhjNitrVAo9ZXRkWgotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============2816355619936721129==--