From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: network@lists.ipfire.org
Subject: [PATCH] network check if a zone exist before executing commands
Date: Wed, 21 Jun 2017 09:45:28 +0200 [thread overview]
Message-ID: <1498031128-7530-1-git-send-email-jonatan.schlag@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
We checked if a zone name was valid so
network zone net0 ... fails when theres was no zone net0.
net0 is a valid zone name so we jumped into the wrong if part.
We now check if a zone exist and when now
network zone net0 ... is called when no zone net0 exists
we print an error message.
This behaviour is similar to network port .., there we do the same thing with port_exists
Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
src/network | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network b/src/network
index ea7f7d6..20f65e8 100644
--- a/src/network
+++ b/src/network
@@ -551,7 +551,7 @@ cli_zone() {
local action
local zone
- if zone_name_is_valid ${1}; then
+ if zone_exists ${1}; then
zone=${1}
action=${2}
shift 2
--
2.6.3
reply other threads:[~2017-06-21 7:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498031128-7530-1-git-send-email-jonatan.schlag@ipfire.org \
--to=jonatan.schlag@ipfire.org \
--cc=network@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox