Re: [PATCH 1/7] settings: remove dot from log message

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Hi,

this commit message says that you removed the dot, but it is still
there...

-Michael

On Tue, 2017-07-04 at 17:46 +0200, Jonatan Schlag wrote:
> The dots at the end of log messages can be confusing.
> Especially behind variables,it is often unclear if the dot was part
> of the variable or not
> which make debugging much harder.
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/functions/functions.settings | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/functions/functions.settings
> b/src/functions/functions.settings
> index 0e50bf1..9efbe8e 100644
> --- a/src/functions/functions.settings
> +++ b/src/functions/functions.settings
> @@ -159,7 +159,7 @@ settings_write() {
>  		return ${EXIT_ERROR}
>  	fi
>  
> -	log DEBUG "Writing settings file ${settings_file}."
> +	log DEBUG "Writing settings file '${settings_file}'."
>  
>  	mkdir -p $(dirname ${settings_file}) 2>/dev/null
>  	> ${settings_file}

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]