From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 1/7] settings: remove dot from log message
Date: Tue, 04 Jul 2017 17:06:55 +0100
Message-ID: <1499184415.2362.5.camel@ipfire.org>
In-Reply-To: <1499183171-24236-1-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1784840054855021674=="
List-Id: <network.lists.ipfire.org>

--===============1784840054855021674==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi,

this commit message says that you removed the dot, but it is still
there...

-Michael

On Tue, 2017-07-04 at 17:46 +0200, Jonatan Schlag wrote:
> The dots at the end of log messages can be confusing.
> Especially behind variables,it is often unclear if the dot was part
> of the variable or not
> which make debugging much harder.
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/functions/functions.settings | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/functions/functions.settings
> b/src/functions/functions.settings
> index 0e50bf1..9efbe8e 100644
> --- a/src/functions/functions.settings
> +++ b/src/functions/functions.settings
> @@ -159,7 +159,7 @@ settings_write() {
>  		return ${EXIT_ERROR}
>  	fi
>  
> -	log DEBUG "Writing settings file ${settings_file}."
> +	log DEBUG "Writing settings file '${settings_file}'."
>  
>  	mkdir -p $(dirname ${settings_file}) 2>/dev/null
>  	> ${settings_file}

--===============1784840054855021674==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlpXNzBmQUFvSkVJQjU4UDl2a0FrSHIvRVAvMmJXZlBacmQzWjRJb0xlNDFuT09Hb2sK
Y201RjQ1emdNNGVmT3UyaEdzZUlxV3dDVTNjUysreGVMdjU0Mi8ySHhxOGIvWGVUeWk5aFFvVjIy
R1B0KzI4MwpWSTdnVzY1aXg2cmxFUVZxMTErWlBLZjdjSjNTSVplYmNQK1JjL25GS0JUT0FUZDY5
TWU4bG1nQnBLRG1ZNU1TClp6eGVGazhEemMyOS9NM2RQM0phSXRQNlRrNTJPQUdOUGYzam1DVnNZ
T1VDTzJnbGt4SXJsQTdwcVA3QUx0TloKd0U2NnNCS0hWc08xSzdvV2xEZkpFRWFNY2dIUFJSVXV2
S1g1eXhtdlRPN2lHVmNaaUFNd3ErbS9mMDBGcUUvVgp5SXZ1d0pEMFVjQTNnVjRxK3VnbU1LOVp5
Y1NWb2I0M3lVUCsranZid2FJTTRLYnk0VkRNeXdyeDVNV0FsNEJPCklhQ3Z5RHRHSHQ5cWRPblhz
SUZhb1BZeVgyYVVLZXFPMXZjWm5JTSsranZrdElxUEZGOThoYVN5aXZYY3E5R0gKVVEvRVJCRGV2
a01oTzFxb0Nhbld3WExGK1VMWVVUK1A3UkJKakI5cjhSSXYwY2RLbEVycElVRlkrblZCZURZLwps
dWVLTGVFLzh4L3Zic2ppRjZGTEh2N0IvUHpYc2R5LytJUjZ0cGN4NE5BVTJualF1T1laNm9PeWZ6
RXNjRTJDCkt4NW9ETW05UmdFSkVtc3Jvd1E3Qi9JZGpWZmMyTUxHRi9EQ25Xd2FWaXI2MUVvSWNo
bFlsanhXaks0SGFzVS8KOXEzRG5vNW1PbzAyU1VLeXlkeVVNWldQakFHQkdzRk1LUEhpNEMvY09t
aFVtV2sxQXFsWDRSdlFFV2syd0NHcApXbUxxeU9OUGFiWjZxZzFBT1QzQgo9Z01HcwotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============1784840054855021674==--