From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: network@lists.ipfire.org
Subject: [PATCH 1/2] settings: remove dot from log message
Date: Wed, 05 Jul 2017 16:02:35 +0200 [thread overview]
Message-ID: <1499263356-10418-1-git-send-email-jonatan.schlag@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
The dots at the end of log messages can be confusing.
Especially behind variables,it is often unclear if the dot was part of the variable or not
which make debugging much harder.
Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
src/functions/functions.settings | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/functions/functions.settings b/src/functions/functions.settings
index 0e50bf1..c73349a 100644
--- a/src/functions/functions.settings
+++ b/src/functions/functions.settings
@@ -159,7 +159,7 @@ settings_write() {
return ${EXIT_ERROR}
fi
- log DEBUG "Writing settings file ${settings_file}."
+ log DEBUG "Writing settings file '${settings_file}'"
mkdir -p $(dirname ${settings_file}) 2>/dev/null
> ${settings_file}
--
2.6.3
next reply other threads:[~2017-07-05 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 14:02 Jonatan Schlag [this message]
2017-07-05 14:02 ` [PATCH 2/2] config: remove old hashes Jonatan Schlag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499263356-10418-1-git-send-email-jonatan.schlag@ipfire.org \
--to=jonatan.schlag@ipfire.org \
--cc=network@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox