From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: network@lists.ipfire.org
Subject: [PATCH 8/8] zone: Check early if a id is valid
Date: Wed, 05 Jul 2017 16:19:53 +0200 [thread overview]
Message-ID: <1499264393-13700-8-git-send-email-jonatan.schlag@ipfire.org> (raw)
In-Reply-To: <1499264393-13700-1-git-send-email-jonatan.schlag@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
src/functions/functions.zone | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/functions/functions.zone b/src/functions/functions.zone
index 776b63b..d121225 100644
--- a/src/functions/functions.zone
+++ b/src/functions/functions.zone
@@ -550,7 +550,12 @@ zone_config() {
zone_config_new "${zone}" "$@"
;;
destroy)
- zone_config_destroy "${zone}" "$@"
+ local id=${1}
+ if zone_config_id_is_valid ${zone} ${id}; then
+ zone_config_destroy "${zone}" "$@"
+ else
+ log ERROR "${id} is not a valid id"
+ fi
;;
edit)
zone_config_edit "${zone}" "$@"
--
2.6.3
prev parent reply other threads:[~2017-07-05 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 14:19 [PATCH 1/8] zone: new function zone_config_get_new_id Jonatan Schlag
2017-07-05 14:19 ` [PATCH 2/8] zone: new function zone_config_id_is_valid Jonatan Schlag
2017-07-05 14:19 ` [PATCH 3/8] zone: new function zone_config_get_hook_from_id Jonatan Schlag
2017-07-05 14:19 ` [PATCH 4/8] zone: Introduce id feature Jonatan Schlag
2017-07-05 14:19 ` [PATCH 5/8] header-zone: refactor hook_config_destroy Jonatan Schlag
2017-07-05 14:19 ` [PATCH 6/8] header-zone: refactor hook_config_edit Jonatan Schlag
2017-07-05 14:19 ` [PATCH 7/8] zone: change edit syntax for config Jonatan Schlag
2017-07-05 14:19 ` Jonatan Schlag [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499264393-13700-8-git-send-email-jonatan.schlag@ipfire.org \
--to=jonatan.schlag@ipfire.org \
--cc=network@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox