From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 1/5] zone: fix zone_config()
Date: Mon, 17 Jul 2017 16:20:42 -0400
Message-ID: <1500322842.2548.7.camel@ipfire.org>
In-Reply-To: <1500305066-12510-1-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7964638547764413911=="
List-Id: <network.lists.ipfire.org>

--===============7964638547764413911==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi,

I merged this patchset, but there is a few comments left.

Maybe you can have a look at them and if you think it suits, please
send some patches to get rid of any problems.

-Michael

On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/functions/functions.zone | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/functions/functions.zone
> b/src/functions/functions.zone
> index acf68f5..11a8dc2 100644
> --- a/src/functions/functions.zone
> +++ b/src/functions/functions.zone
> @@ -565,9 +565,9 @@ zone_config() {
>  			# TODO This could be also a valid hid
>  			local id=${cmd}
>  
> -			if zone_config_id_is valid ${zone} ${id} &&
> [[ ${1} == "edit" ]]; then
> +			if zone_config_id_is_valid ${zone} ${id} &&
> [[ ${1} == "edit" ]]; then
>  				shift 1
> -				zone_config_edit "${zone}"
> "${id}""$@"
> +				zone_config_edit "${zone}" "${id}"
> "$@"
>  			else
>  				error "Unrecognized argument:
> ${cmd}"
>  				cli_usage root-zone-config-
> subcommands

--===============7964638547764413911==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlpiUndhQUFvSkVJQjU4UDl2a0FrSHRVVVAvMC9NekJDajkzbnRybXhEVTBIdTN4dTcK
UVY5YU12S3o2VU1lbjNZcVV4L0s3VE1MWTh6cExENllOT0tVWnVmYnJMVUwyQ1pWWHhRVU5LS0lk
SUJQZHhCLwphbUQvQ2ZZU3cvZm9naFVsc1pUd0ZIb3FJRzNjaVBYYzF1ZnQrRS9kNklNcldBbUpn
U0kxVjBvS1lTWnJQMDRGCm9IemEyQXk2dzVjS0xCSkhkZWN3OGtuakY0UzJpMlZLQVNvbXJ1L2NB
MThCeVcvNlJpSWhGQ1B1dHBEZmFkR1kKN3VHcUJob28yQ1hBZEltQUErV2lKNitabDlFUWlGRXFY
WFhWK1RtRFRXZnhGTEZMM2d6UHhicGhmVFVhOXRhNApTQ3ZFVEM1K05YYTZVQVpta1IyTG54Q05u
bHRaT21SOUllN0R5RWlGMTNLUHNLTjkwMDdDNUZTbTVSemYrZktOCnpTYW1NTk4zVTRYVzk1ZGVF
dmVPN3pZanhVemtBbHhTNTc5MmF0cUo5Wit5dy9EQnkzeGh3SS9OaVFXd0UyZ0sKc1phd1ZJd3VF
dFhOelh2Lzd5bjhvbmVQcUlqR2VUQWdvNzdkT0JRc0ZZS2wzS1FaZU9sbmVBMmJBaG9MRDEyQgpR
YnF6WTRqV3hQL0N1YVZYUUJJRk9UV1dmZWUzRXdFb1crcXh4emhJblRZQ2oyQW1PWFM4eUlIQlN3
WlJuK3hvCnF4U0Z5cDJreG8waE0zSEVodnVnSDA3UUtNZlkrMk5paCthRURudVR3bXNJd0xYdlVY
TlU3ZEdRUGNmMUQ3amwKRjRBVDVGUkQ5SCtrSUN5bGcvMUYrSU1QUzNWMVVSWXNnQUFiR2hKVWFC
Sk5OQkpzN3ovSzFZZEtlODhlUEoraAorVCtQYyt1TnRGemFmc0JOUzVOLwo9WDZWTgotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============7964638547764413911==--