From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 2/5] header-zone fix hook_config_edit()
Date: Mon, 17 Jul 2017 16:21:02 -0400 [thread overview]
Message-ID: <1500322862.2548.8.camel@ipfire.org> (raw)
In-Reply-To: <1500305066-12510-2-git-send-email-jonatan.schlag@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> This function accepted only two arguments so new cmd coudl be passed.
> We accept now more then 2 arguments.
>
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> src/header-zone | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/header-zone b/src/header-zone
> index 2e3fa09..98b0ce7 100644
> --- a/src/header-zone
> +++ b/src/header-zone
> @@ -225,7 +225,7 @@ hook_config_destroy() {
> }
>
> hook_config_edit() {
> - assert [ $# -eq 2 ]
> + assert [ $# -ge 2 ]
> local zone=${1}
> # The id must be the id and not the hid.
> local id=${2}
Please have a blank line after any assertions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-07-17 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:24 [PATCH 1/5] zone: fix zone_config() Jonatan Schlag
2017-07-17 15:24 ` [PATCH 2/5] header-zone fix hook_config_edit() Jonatan Schlag
2017-07-17 20:21 ` Michael Tremer [this message]
2017-07-17 15:24 ` [PATCH 3/5] dhcp: check the config indide the hook_parse_cmdline() function Jonatan Schlag
2017-07-17 15:24 ` [PATCH 4/5] config: add new functions Jonatan Schlag
2017-07-17 20:22 ` Michael Tremer
2017-07-17 20:23 ` Michael Tremer
2017-07-17 15:24 ` [PATCH 5/5] header-config: add generic hook_edit function Jonatan Schlag
2017-07-17 20:20 ` [PATCH 1/5] zone: fix zone_config() Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500322862.2548.8.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=network@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox