From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 2/5] header-zone fix hook_config_edit()
Date: Mon, 17 Jul 2017 16:21:02 -0400
Message-ID: <1500322862.2548.8.camel@ipfire.org>
In-Reply-To: <1500305066-12510-2-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2085258476768997181=="
List-Id: <network.lists.ipfire.org>

--===============2085258476768997181==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> This function accepted only two arguments so new cmd coudl be passed.
> We accept now more then 2 arguments.
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/header-zone | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/header-zone b/src/header-zone
> index 2e3fa09..98b0ce7 100644
> --- a/src/header-zone
> +++ b/src/header-zone
> @@ -225,7 +225,7 @@ hook_config_destroy() {
>  }
>  
>  hook_config_edit() {
> -	assert [ $# -eq 2 ]
> +	assert [ $# -ge 2 ]
>  	local zone=${1}
>  	# The id must be the id and not the hid.
>  	local id=${2}

Please have a blank line after any assertions.

--===============2085258476768997181==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlpiUnd1QUFvSkVJQjU4UDl2a0FrSFJNc1FBSTNnaVlFdEYyaytjWERuU1FUSEI1aTMK
bkpaWERnZVhjZyttMjI1TGZRNTVFTTRLNG5qNjEzR1pvNlRTQTJTMDU5RUVtWjdPbW55cXl3dGQv
WDVubXlFWgpzZmtvdW44TW1WN3RXa0lNMzhVeVdSWExncW5QdEFISUFQWVNBSGJRV3U2Y1N1Uy9W
em1BNlIrM1RIZlBxdDU5CnB5OUlwUjQxNXRVNG9PMVZaQjl3RDJiK2F6VVpQWE9CZXBBUWhJbkJj
aUdvbGRrQmVMbS9PMit0ODIxNy9nRG4Kb0pWNVVELzJIYmFYbmlmTVBNeFhQZFJubnFLbUpMU3dz
Z053QWcvUWhuSWkrdTJSaVpGRGFuMGwxbGR0QkhBWQp4elFHMXdpSTdWa0dwVnoxdmlDazZxbkFq
M3JOU24wVWpKLzdaTElsQlMrQUsxQmJkWFRJUExmanpNeEs2dGc0CmVaallSUzRuV09LdW1iQ0E5
Q0FGa25FUVpqMUZ3N05xVFE0REJia3Z0eTlHd0RsTWRHRXdxTVpiYkR4SHYxVXEKbTk1T21NVDJ3
T2xQazI4T3loQU52a1pQOEhUYnlUWXB4a09za3B2WGR4MlFuMzdEeUJIb1F0NzhkeWhqL1FnNwpD
Qjk2UmxJUHZ3WXduTjIySVZ0S3k2QVR1aG5CM0RRcGFyaVdXK2VYcEoxK0JIYngydnlKYytWL2dI
MkRwbkszCjZPVVl1WTJBM1FqdUFSZmQza0RobWZZbWwwT1NCeFRKN3dub1ZoM0FuM0YwSVVpQW1m
TVUrVnA1OEhHcU1UcysKYnV5WmdEOE8zY2o4Vm9ueHJLaDUxS2dDaTlZTGg0ckUrWVVTdXNqVStn
WGplYmtGbE0weTFEdGhSZ3RNN1hTUQpEcGpudmdvc1hQdFVIcW9GZFY5ZQo9akFiQQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============2085258476768997181==--