From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 4/5] config: add new functions
Date: Mon, 17 Jul 2017 16:22:46 -0400
Message-ID: <1500322966.2548.10.camel@ipfire.org>
In-Reply-To: <1500305066-12510-4-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1950037572907198687=="
List-Id: <network.lists.ipfire.org>

--===============1950037572907198687==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi,

On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> This patch add two new functions:
> config_get_id_from_config()
> config_get_hook_from_config
> 
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
>  src/functions/functions.config | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/src/functions/functions.config
> b/src/functions/functions.config
> index 854f490..e11a1c2 100644
> --- a/src/functions/functions.config
> +++ b/src/functions/functions.config
> @@ -51,3 +51,23 @@ config_domainname() {
>  	# the domain part.
>  	print "${hostname#*.}"
>  }
> +
> +config_get_id_from_config() {
> +	# This function returns the id for a given config name
> +	# Example 'dhcp.0' => 0
> +	assert [ $# -eq 1 ]
> +	local config=${1}
> +
> +	local hook=$(config_get_hook_from_config ${config})
> +	echo "${config//"${hook}."/}"
> +
> +}

There is an extra empty line.

And calling config_get_hook_from_config() is an expensive call. It
forks a subshell and loads the hook and so on.

I am sure that you can find the ID without knowing what is coming
before. That would increase performance of this function tremendously.

> +
> +config_get_hook_from_config() {
> +	# This function returns the hook for a given config name
> +	# Example 'dhcp.0' => dhcp
> +	assert [ $# -eq 1 ]
> +	local config=${1}
> +
> +	echo "${config//.*[[:digit:]]/}"
> +}

--===============1950037572907198687==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlpiUnlXQUFvSkVJQjU4UDl2a0FrSEYwY1AvUkU3U1VDejJMMkdwanhTczJxZDZHclAK
M2s3elFpRnRQaEJsRUdMZHUxOHptbWFYenBIeldBb0Z3Z2tPRnZRQ3VURFlUZnBWREZQNlBmZVdi
TmRvdko4dwpmNjY5M3RJaE5qc0Y4UmtQa3hNaExxNlZPcVlqQXRrZDFWMG40WHJMQ2JrMXZhY3hH
MUsvK0w0Vm0rd0dDMk5sCldnWEZjdy9wSGgxSnJEcU5YTWo2ODRQMVBVRkdud1lReFNWMGcwQ1hs
MC9DTUIwcGdhekRIUU4yeWpMaWhuNUsKV3VlYVZlcVZDRS9jZVgyZmhZOVl6bkJ3UkRaSW9FeHhl
Qktic1k5TllzWmdrUjAvNVVUTE5nL3g3eHV6TWhJeApUL3BvZnJFZDhYWXpYUStleTIwc2c3RWpR
Uzdhbkcxb3FndUtIdjVEUHI2aXZ1cEN0aVJkNFlDVTFMYkEzUUdOCnpaaTJ5K3BPb1VNeFI2NXZZ
ZTdXV1lVSkIzVUxiRVJPa1lSK0ZrZ1VRYWZ6V0p0QWNtUm50bWQwRkIwdVY3dm0KQUVaS3ZyUDRH
TnBvQUxHcjdJampMMEhuZDN5cFg5UThkdnMrNXc5WHlmZHFEQVU4TFBFVTNoVnlMY3JESXZiRQpj
WkU2MW85MnFTM1VSNGpnU2p3Y0N0VUNNSjlUbEVPWlpDM2NyN3UzRWtmekFvVWNIdEpYVXEybVlK
bDl2TlVpCmIzWWVCekRCSk52TzhWaVpjN3BCajc0c3htK0p5MXNRTStVT2JOYUpPN0lXM01IUUZt
MFhTTHFVVUpqdCtKcmwKQTN0T0lKVzJKRmlGbTdsN0EwTk16M3BLZ0NTRXFkQXk3YTZ6bjlrR2Yy
L1RlNFlwSVh4Si9JcDZvOTdTTkNvMwovNXhGMktEdWFwcnE2aXZOUmd2bgo9ZWI0cgotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============1950037572907198687==--