From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 4/5] config: add new functions
Date: Mon, 17 Jul 2017 16:23:55 -0400
Message-ID: <1500323035.2548.11.camel@ipfire.org>
In-Reply-To: <1500322966.2548.10.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1217021749267058055=="
List-Id: <network.lists.ipfire.org>

--===============1217021749267058055==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Mon, 2017-07-17 at 16:22 -0400, Michael Tremer wrote:
> Hi,
> 
> On Mon, 2017-07-17 at 17:24 +0200, Jonatan Schlag wrote:
> > This patch add two new functions:
> > config_get_id_from_config()
> > config_get_hook_from_config
> > 
> > Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> > ---
> >  src/functions/functions.config | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/src/functions/functions.config
> > b/src/functions/functions.config
> > index 854f490..e11a1c2 100644
> > --- a/src/functions/functions.config
> > +++ b/src/functions/functions.config
> > @@ -51,3 +51,23 @@ config_domainname() {
> >  	# the domain part.
> >  	print "${hostname#*.}"
> >  }
> > +
> > +config_get_id_from_config() {
> > +	# This function returns the id for a given config name
> > +	# Example 'dhcp.0' => 0
> > +	assert [ $# -eq 1 ]
> > +	local config=${1}
> > +
> > +	local hook=$(config_get_hook_from_config ${config})
> > +	echo "${config//"${hook}."/}"
> > +
> > +}
> 
> There is an extra empty line.
> 
> And calling config_get_hook_from_config() is an expensive call. It
> forks a subshell and loads the hook and so on.
> 
> I am sure that you can find the ID without knowing what is coming
> before. That would increase performance of this function
> tremendously.

Actually I am wrong here. This is the function below :)

Still you can avoid calling it...

> 
> > +
> > +config_get_hook_from_config() {
> > +	# This function returns the hook for a given config name
> > +	# Example 'dhcp.0' => dhcp
> > +	assert [ $# -eq 1 ]
> > +	local config=${1}
> > +
> > +	echo "${config//.*[[:digit:]]/}"
> > +}

--===============1217021749267058055==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlpiUnpiQUFvSkVJQjU4UDl2a0FrSDRQc1AvaU11VkNBVGpHVmhKbnRDeEtIOEx5bTcK
dXV5NFBJckxtL2NiNmNNd0IxQVhkUk5wcjNTUHpmd1RQYk1qcElqbU1EcHZ2eGNMS2VKcDdNVUlH
d2RTUUZYWAo5aVBEcC8reGlBQ25vNHhzNkJSWmtXMGVCNUlDQXFtY3phTGhHb0tCRkZ2RUlZdkZJ
OUc2MEJNYVZnUXV3VjZ4CmRKcW9zd0czUlc4ckVkUE1QWTZxMlNEelpUSW1VejJOQTZ0WWMwYmMw
VUkvRk83T0FjMVdrdFBNVlZwYnRka3cKaGtFN1cxMXVBUWtrUlVvVnRXNStDWDQxNjlwVWxSd1ln
K2k3MGF5VFkyOW16c0N1QUVVdW1sR09FR2h6UVVPQwoxOEdtTjZBZUlBQW9IbFVjR2pnaWpLQk05
a1JFQWJiNkNQREhWc010L241WVVFZFQ2MHNqL3pSVVdTTXYyaXU5Cnkya05DQ0ZhNjZrRnIxVlFP
aEFRUmEvTm1JNndKOXAvdnljaHZhaXNCazhmS2xkY0NHUm1WWEdRSXRiSmxCYzMKU2VqcEJnUnYy
NVcvZ25FcFFUQ0wxM3I5N093UXJ5NzJxaFRhMU03aXdKS3hKME9SRVRaR3hjeVE5bVNndWdaSQpI
Ylg3bmNrbE5EWkRmMGFOeTEzcFo4ZGpkajZiancwMi84MWNiNmYyTXp0TWV4RUNTNlpDaFI2Q1JP
UDV3TjdjCjl5VDY5bGxseDZhRDNEaTRwWWtTUkV4bDg1K29hNXc5N0JqS3FCL2dVR1R5QnVlVitR
MmJIMlBKM25DRmFKS0UKRGI0YytBa0YrWENscDlYdVgwSzNFdVBaem5lMVJ0S1lTTXNRTTJWSXQw
V2NRdUMzQTk4bzB6NTZpUjBxRDZlQQo4RXNRU0ExZHVMYkk4M000bVg0Vwo9NzFQUwotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============1217021749267058055==--