From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: network@lists.ipfire.org
Subject: [PATCH] list: fix a bug
Date: Wed, 19 Jul 2017 15:21:51 +0200
Message-ID: <1500470511-21430-1-git-send-email-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1537097065564656183=="
List-Id: <network.lists.ipfire.org>

--===============1537097065564656183==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

When the list is called "list" we have a problem because
${list}=3D"list"
and ${!list}=3D"list"
This creates effects nobody wants and which are also not so easy to understan=
d.
To avoid such problems in the future we now throw an assertation when the lis=
t is called list.

Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
 src/functions/functions.list | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/functions/functions.list b/src/functions/functions.list
index 26ba6c3..ff73b04 100644
--- a/src/functions/functions.list
+++ b/src/functions/functions.list
@@ -25,6 +25,7 @@
 list_append() {
 	local list=3D${1}
 	assert isset list
+	assert [ ${list} !=3D "list" ]
 	shift
=20
 	local arg
@@ -40,6 +41,7 @@ list_append_one() {
 	shift
=20
 	assert isset list
+	assert [ ${list} !=3D "list" ]
=20
 	if [ -n "${!list}" ]; then
 		printf -v ${list} -- "${!list} $@"
@@ -53,6 +55,7 @@ list_remove() {
 	shift
=20
 	assert isset list
+	assert [ ${list} !=3D "list" ]
=20
 	local _list k
 	for k in ${!list}; do
@@ -127,6 +130,10 @@ list_join() {
 	local list=3D${1}
 	local delim=3D${2}
=20
+	assert isset list
+	assert isset delim
+	assert [ ${list} !=3D "list" ]
+
 	local ret
 	printf -v ret "${delim}%s" ${!list}
=20
--=20
2.6.3


--===============1537097065564656183==--