From: Michael Tremer <michael.tremer@ipfire.org>
To: network@lists.ipfire.org
Subject: Re: [PATCH 8/8] autocompletion: use hids instead of ids
Date: Tue, 25 Jul 2017 23:30:20 +0100 [thread overview]
Message-ID: <1501021820.20312.37.camel@ipfire.org> (raw)
In-Reply-To: <1500998833-10543-9-git-send-email-jonatan.schlag@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Tue, 2017-07-25 at 18:07 +0200, Jonatan Schlag wrote:
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> src/bash-completion/network | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/bash-completion/network b/src/bash-completion/network
> index 820c2d4..529a772 100644
> --- a/src/bash-completion/network
> +++ b/src/bash-completion/network
> @@ -421,7 +421,7 @@ _network_zone_subcommand_config() {
>
> local words=( $@ )
>
> - local commands="destroy list new $(network raw list-zone-config-ids
> ${zone})"
> + local commands="destroy list new $(network raw list-zone-config-hids
> ${zone})"
>
> local cmd="$(_network_find_on_cmdline "${commands}")"
> if [[ -z "${cmd}" ]]; then
> @@ -442,7 +442,7 @@ _network_zone_subcommand_config() {
> *)
> # Check if we get a valid id
> # TODO: We should also accept a valid hid
> - if network raw zone-config-id-is-valid ${zone}
> ${cmd}; then
> + if network raw zone-config-id-is-valid ${zone} ${cmd}
> || network raw zone-config-hid-is-valid ${zone} ${cmd}; then
> _network_zone_subcommand_config_subcommand
> ${zone} ${args}
> fi
> ;;
Again, is it not smarter to assume that a HID has been given instead of an ID?
Saves us a call of the second function...
-Michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-07-25 22:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 16:07 Add hids Jonatan Schlag
2017-07-25 16:07 ` [PATCH 1/8] zone: add config hid functions Jonatan Schlag
2017-07-25 22:22 ` Michael Tremer
2017-07-25 16:07 ` [PATCH 2/8] zone: accept also hids in zone_config() Jonatan Schlag
2017-07-25 22:27 ` Michael Tremer
2017-07-25 16:07 ` [PATCH 3/8] zone: config list print also hids Jonatan Schlag
2017-07-25 22:28 ` Michael Tremer
2017-07-25 16:07 ` [PATCH 4/8] hook: also hook_hid is a valid command Jonatan Schlag
2017-07-25 16:07 ` [PATCH 5/8] header-config: add generic hhok_hid function Jonatan Schlag
2017-07-25 22:29 ` Michael Tremer
2017-07-25 16:07 ` [PATCH 6/8] raw: add command list-zone-config-hids Jonatan Schlag
2017-07-25 16:07 ` [PATCH 7/8] raw: add command zone-config-hid-is-valid Jonatan Schlag
2017-07-25 16:07 ` [PATCH 8/8] autocompletion: use hids instead of ids Jonatan Schlag
2017-07-25 22:30 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501021820.20312.37.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=network@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox