public inbox for network@lists.ipfire.org
 help / color / mirror / Atom feed
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: network@lists.ipfire.org
Subject: [PATCH 3/3] This recipe sets settings which are usually equal for each test
Date: Tue, 24 Jul 2018 11:09:51 +0200	[thread overview]
Message-ID: <20180724090951.11769-3-jonatan.schlag@ipfire.org> (raw)
In-Reply-To: <20180724090951.11769-1-jonatan.schlag@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

Some settings are equal for each test, so it is easier to write them
down once and include them then in every test.

We have two version here (all and alice) to avoid that bob is booted
when we are using only alice. (The all statement is substituded to
alice: and bob: so we have a command for bob and the machine is booted,
which costs time.)

Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
 Makefile.am                               | 8 ++++++--
 test/nitsi/include/alice_network-settings | 1 +
 test/nitsi/include/network-settings       | 1 +
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 test/nitsi/include/alice_network-settings
 create mode 100644 test/nitsi/include/network-settings

diff --git a/Makefile.am b/Makefile.am
index 66d2e8d..1f75ef3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -589,13 +589,17 @@ NITSI_INCLUDE_RECIPES = \
 	test/nitsi/include/make-install \
 	test/nitsi/include/alice_make-install \
 	test/nitsi/include/alice_network-reset \
-	test/nitsi/include/network-reset
+	test/nitsi/include/network-reset \
+	test/nitsi/include/alice_network-settings \
+	test/nitsi/include/network-settings
 
 EXTRA_DIST += \
 	test/nitsi/include/make-install.in \
 	test/nitsi/include/alice_make-install.in \
 	test/nitsi/include/alice_network-reset \
-	test/nitsi/include/network-reset
+	test/nitsi/include/network-reset \
+	test/nitsi/include/alice_network-settings \
+	test/nitsi/include/network-settings
 
 CLEANFILES += \
 	test/nitsi/include/make-install \
diff --git a/test/nitsi/include/alice_network-settings b/test/nitsi/include/alice_network-settings
new file mode 100644
index 0000000..1c071de
--- /dev/null
+++ b/test/nitsi/include/alice_network-settings
@@ -0,0 +1 @@
+alice: network settings DEBUG=1
diff --git a/test/nitsi/include/network-settings b/test/nitsi/include/network-settings
new file mode 100644
index 0000000..535fe4c
--- /dev/null
+++ b/test/nitsi/include/network-settings
@@ -0,0 +1 @@
+all: network settings DEBUG=1
-- 
2.11.0


      parent reply	other threads:[~2018-07-24  9:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  9:09 [PATCH 1/3] Add make install recipe for alice only Jonatan Schlag
2018-07-24  9:09 ` [PATCH 2/3] This recipe resets the network to a clean state Jonatan Schlag
2018-07-24  9:09 ` Jonatan Schlag [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724090951.11769-3-jonatan.schlag@ipfire.org \
    --to=jonatan.schlag@ipfire.org \
    --cc=network@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox