[PATCH] BUG11177: pppoe password not required anymore

Michael Tremer michael.tremer at ipfire.org
Thu Sep 8 13:59:09 CEST 2016


Thanks. That was quick.

On Thu, 2016-09-08 at 08:36 +0200, Alexander Marx wrote:
> fixes: #11177
> 
> There are providers which do not use passwords anymore.
> For this reason the password field is no longer mandatory.
> 
> Signed-off-by: Alexander Marx <alexander.marx at ipfire.org>
> ---
>  html/cgi-bin/pppsetup.cgi | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
> index 36d0ced..4b45ee5 100644
> --- a/html/cgi-bin/pppsetup.cgi
> +++ b/html/cgi-bin/pppsetup.cgi
> @@ -103,10 +103,7 @@ elsif ($pppsettings{'ACTION'} eq $Lang::tr{'save'})
>                  if ($pppsettings{'USERNAME'} eq '') {
>                          $errormessage = $Lang::tr{'username not set'};
>                          goto ERROR; }
> -                if ($pppsettings{'PASSWORD'} eq '') {
> -                        $errormessage = $Lang::tr{'password not set'};
> -                        goto ERROR; }
> -        }
> +		}
>  
>          if ($pppsettings{'TIMEOUT'} eq '') {
>                  $errormessage = $Lang::tr{'idle timeout not set'};
> @@ -927,7 +924,7 @@ print <<END
>  <tr>
>          <td width='25%'>$Lang::tr{'username'} <img src='/blob.gif'
> alt='*' /></td>
>          <td width='25%'><input type='text' name='USERNAME'
> value='$pppsettings{'USERNAME'}' /></td>
> -        <td width='25%'>$Lang::tr{'password'} <img src='/blob.gif'
> alt='*' /></td>
> +        <td width='25%'>$Lang::tr{'password'} </td>
>          <td width='25%'><input type='password' name='PASSWORD'
> value='$pppsettings{'PASSWORD'}' /></td>
>  </tr>
>  <tr>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ipfire.org/pipermail/development/attachments/20160908/dcd461fb/attachment.sig>


More information about the Development mailing list