[PATCH] tor: Fix tor permissions if presant via update.sh

Peter Müller peter.mueller at ipfire.org
Mon Jun 10 19:12:00 BST 2019


Hello Michael,

as mentioned in https://bugzilla.ipfire.org/show_bug.cgi?id=12088#c11 ,
the "install.sh" script of the Tor addon contains all required steps.

Since "update.sh" calls "install.sh" at the end of the file, everything
should be fine after an update as well - which is not. However, due to
this, I do not think putting it into "update.sh" makes sense either.

Thanks, and best regards,
Peter Müller

Michael Tremer:
> Hi,
> 
> Thanks for sending in that patch.
> 
> But I think instead of doing this in the Core Update, this change should be applied in the tor update scripts.
> 
> -Michael
> 
>> On 10 Jun 2019, at 12:36, Erik Kapfer <ummeegge at ipfire.org> wrote:
>>
>> Signed-off-by: Erik Kapfer <ummeegge at ipfire.org>
>> ---
>> config/rootfiles/core/133/update.sh | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/config/rootfiles/core/133/update.sh b/config/rootfiles/core/133/update.sh
>> index a05ad0741..3ecb5651b 100644
>> --- a/config/rootfiles/core/133/update.sh
>> +++ b/config/rootfiles/core/133/update.sh
>> @@ -71,6 +71,11 @@ sudo -u nobody /srv/web/ipfire/cgi-bin/vpnmain.cgi
>> /etc/init.d/squid start
>> /etc/init.d/collectd restart
>>
>> +# Set new permissions for tor
>> +if [ -d "/var/lib/tor" ]; then
>> +    chown -R tor:tor /var/lib/tor
>> +fi
>> +
>> # Finish
>> /etc/init.d/fireinfo start
>> sendprofile
>> -- 
>> 2.12.2
>>
> 

-- 
The road to Hades is easy to travel.
	-- Bion of Borysthenes


More information about the Development mailing list