[PATCH] tor: Fix tor permissions if presant via update.sh

Michael Tremer michael.tremer at ipfire.org
Mon Jun 10 19:51:06 BST 2019


Hi,

Yes that will be it. The backup stores permissions and ownership.

Please move the chown line to after the backup is being restored and you will be fine.

-Michael

> On 10 Jun 2019, at 19:36, Paul Simmons <mbatranch at gmail.com> wrote:
> 
> On 6/10/19 1:12 PM, Peter Müller wrote:
>> Hello Michael,
>> 
>> as mentioned in https://bugzilla.ipfire.org/show_bug.cgi?id=12088#c11 ,
>> the "install.sh" script of the Tor addon contains all required steps.
>> 
>> Since "update.sh" calls "install.sh" at the end of the file, everything
>> should be fine after an update as well - which is not. However, due to
>> this, I do not think putting it into "update.sh" makes sense either.
>> 
>> Thanks, and best regards,
>> Peter Müller
>> 
>> Michael Tremer:
>>> Hi,
>>> 
>>> Thanks for sending in that patch.
>>> 
>>> But I think instead of doing this in the Core Update, this change should be applied in the tor update scripts.
>>> 
>>> -Michael
>>> 
>>>> On 10 Jun 2019, at 12:36, Erik Kapfer <ummeegge at ipfire.org> wrote:
>>>> 
>>>> Signed-off-by: Erik Kapfer <ummeegge at ipfire.org>
>>>> ---
>>>> config/rootfiles/core/133/update.sh | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>> 
>>>> diff --git a/config/rootfiles/core/133/update.sh b/config/rootfiles/core/133/update.sh
>>>> index a05ad0741..3ecb5651b 100644
>>>> --- a/config/rootfiles/core/133/update.sh
>>>> +++ b/config/rootfiles/core/133/update.sh
>>>> @@ -71,6 +71,11 @@ sudo -u nobody /srv/web/ipfire/cgi-bin/vpnmain.cgi
>>>> /etc/init.d/squid start
>>>> /etc/init.d/collectd restart
>>>> 
>>>> +# Set new permissions for tor
>>>> +if [ -d "/var/lib/tor" ]; then
>>>> +    chown -R tor:tor /var/lib/tor
>>>> +fi
>>>> +
>>>> # Finish
>>>> /etc/init.d/fireinfo start
>>>> sendprofile
>>>> -- 
>>>> 2.12.2
>>>> 
>>> 
>> 
> 
> Perhaps the restore_backup in install.sh is undoing the ownership?
> 
> p.



More information about the Development mailing list