* [PATCH] RRD graphs: Remove padding around graph images
@ 2021-07-11 18:22 Leo-Andres Hofmann
2021-07-14 16:31 ` Michael Tremer
0 siblings, 1 reply; 3+ messages in thread
From: Leo-Andres Hofmann @ 2021-07-11 18:22 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
The images inherited padding from the general design and
have been resized to fit the layout, resulting in blurred graphs.
This removes the padding and shows the graphs in full size.
Fixes: #12657
Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
---
html/html/themes/ipfire/include/css/style.css | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/html/html/themes/ipfire/include/css/style.css b/html/html/themes/ipfire/include/css/style.css
index 2c727a770..b92f476c4 100644
--- a/html/html/themes/ipfire/include/css/style.css
+++ b/html/html/themes/ipfire/include/css/style.css
@@ -359,7 +359,7 @@ div.rrdimage > ul {
}
div.rrdimage > img {
- box-sizing: border-box;
+ padding: 0;
max-width: 100%;
min-height: 290px;
}
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RRD graphs: Remove padding around graph images
2021-07-11 18:22 [PATCH] RRD graphs: Remove padding around graph images Leo-Andres Hofmann
@ 2021-07-14 16:31 ` Michael Tremer
2021-07-14 20:31 ` Leo Hofmann
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tremer @ 2021-07-14 16:31 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
Hello,
This looks like a valid fix:
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
Would it be a good consideration to render the graphs in SVG format instead? That way they could never be blurry because it is a vector graphic.
Best,
-Michael
> On 11 Jul 2021, at 19:22, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrote:
>
> The images inherited padding from the general design and
> have been resized to fit the layout, resulting in blurred graphs.
> This removes the padding and shows the graphs in full size.
>
> Fixes: #12657
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/html/themes/ipfire/include/css/style.css | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/html/themes/ipfire/include/css/style.css b/html/html/themes/ipfire/include/css/style.css
> index 2c727a770..b92f476c4 100644
> --- a/html/html/themes/ipfire/include/css/style.css
> +++ b/html/html/themes/ipfire/include/css/style.css
> @@ -359,7 +359,7 @@ div.rrdimage > ul {
> }
>
> div.rrdimage > img {
> - box-sizing: border-box;
> + padding: 0;
> max-width: 100%;
> min-height: 290px;
> }
> --
> 2.27.0.windows.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RRD graphs: Remove padding around graph images
2021-07-14 16:31 ` Michael Tremer
@ 2021-07-14 20:31 ` Leo Hofmann
0 siblings, 0 replies; 3+ messages in thread
From: Leo Hofmann @ 2021-07-14 20:31 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
Hi Michael,
thank you for reviewing this. I think that's a good idea, I'll give it a try.
Regards
Leo
Am 14.07.2021 um 18:31 schrieb Michael Tremer:
> Hello,
>
> This looks like a valid fix:
>
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>
> Would it be a good consideration to render the graphs in SVG format instead? That way they could never be blurry because it is a vector graphic.
>
> Best,
> -Michael
>
>> On 11 Jul 2021, at 19:22, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrote:
>>
>> The images inherited padding from the general design and
>> have been resized to fit the layout, resulting in blurred graphs.
>> This removes the padding and shows the graphs in full size.
>>
>> Fixes: #12657
>>
>> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
>> ---
>> html/html/themes/ipfire/include/css/style.css | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/html/html/themes/ipfire/include/css/style.css b/html/html/themes/ipfire/include/css/style.css
>> index 2c727a770..b92f476c4 100644
>> --- a/html/html/themes/ipfire/include/css/style.css
>> +++ b/html/html/themes/ipfire/include/css/style.css
>> @@ -359,7 +359,7 @@ div.rrdimage > ul {
>> }
>>
>> div.rrdimage > img {
>> - box-sizing: border-box;
>> + padding: 0;
>> max-width: 100%;
>> min-height: 290px;
>> }
>> --
>> 2.27.0.windows.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-14 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-11 18:22 [PATCH] RRD graphs: Remove padding around graph images Leo-Andres Hofmann
2021-07-14 16:31 ` Michael Tremer
2021-07-14 20:31 ` Leo Hofmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox