* [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices
@ 2022-05-16 14:48 Michael Tremer
2022-05-16 15:17 ` Peter Müller
0 siblings, 1 reply; 5+ messages in thread
From: Michael Tremer @ 2022-05-16 14:48 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
This has changed in dracut 24 and we have used various hacks to enable
this behaviour again when it would have been so easy to just enable this
parameter.
Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
Reported-by: Dirk Sihling <dsihling(a)web.de>
Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
config/grub2/default | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/grub2/default b/config/grub2/default
index c1b78237e..127d33445 100644
--- a/config/grub2/default
+++ b/config/grub2/default
@@ -1,6 +1,6 @@
GRUB_TIMEOUT=5
GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
GRUB_DEFAULT=saved
-GRUB_CMDLINE_LINUX="panic=10"
+GRUB_CMDLINE_LINUX="rd.auto panic=10"
GRUB_DISABLE_RECOVERY="true"
GRUB_BACKGROUND="/boot/grub/splash.png"
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices
2022-05-16 14:48 [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices Michael Tremer
@ 2022-05-16 15:17 ` Peter Müller
2022-05-16 15:18 ` Michael Tremer
0 siblings, 1 reply; 5+ messages in thread
From: Peter Müller @ 2022-05-16 15:17 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> This has changed in dracut 24 and we have used various hacks to enable
> this behaviour again when it would have been so easy to just enable this
> parameter.
>
> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
> Reported-by: Dirk Sihling <dsihling(a)web.de>
> Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/grub2/default | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/grub2/default b/config/grub2/default
> index c1b78237e..127d33445 100644
> --- a/config/grub2/default
> +++ b/config/grub2/default
> @@ -1,6 +1,6 @@
> GRUB_TIMEOUT=5
> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
> GRUB_DEFAULT=saved
> -GRUB_CMDLINE_LINUX="panic=10"
> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
> GRUB_DISABLE_RECOVERY="true"
> GRUB_BACKGROUND="/boot/grub/splash.png"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices
2022-05-16 15:17 ` Peter Müller
@ 2022-05-16 15:18 ` Michael Tremer
2022-05-16 18:38 ` Peter Müller
0 siblings, 1 reply; 5+ messages in thread
From: Michael Tremer @ 2022-05-16 15:18 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
Please do not merge this yet.
This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot.
-Michael
> On 16 May 2022, at 16:17, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
>
>> This has changed in dracut 24 and we have used various hacks to enable
>> this behaviour again when it would have been so easy to just enable this
>> parameter.
>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
>> Reported-by: Dirk Sihling <dsihling(a)web.de>
>> Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> ---
>> config/grub2/default | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/config/grub2/default b/config/grub2/default
>> index c1b78237e..127d33445 100644
>> --- a/config/grub2/default
>> +++ b/config/grub2/default
>> @@ -1,6 +1,6 @@
>> GRUB_TIMEOUT=5
>> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>> GRUB_DEFAULT=saved
>> -GRUB_CMDLINE_LINUX="panic=10"
>> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>> GRUB_DISABLE_RECOVERY="true"
>> GRUB_BACKGROUND="/boot/grub/splash.png"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices
2022-05-16 15:18 ` Michael Tremer
@ 2022-05-16 18:38 ` Peter Müller
2022-05-17 11:22 ` Michael Tremer
0 siblings, 1 reply; 5+ messages in thread
From: Peter Müller @ 2022-05-16 18:38 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]
Hello Michael,
thanks for your mail, which I unfortunately noticed too late.
So, we have this patch in "next" for the time being, which I consider acceptable, since
it will not reach anybody aside people running IPFire from the "unstable" tree - which
is just as the name implies.
Feel free to revert the patch in "next" at your discretion. I do, however, not consider
it overly problematic to stay there. :-)
Thanks, and best regards,
Peter Müller
> Please do not merge this yet.
>
> This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot.
>
> -Michael
>
>> On 16 May 2022, at 16:17, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
>>
>>> This has changed in dracut 24 and we have used various hacks to enable
>>> this behaviour again when it would have been so easy to just enable this
>>> parameter.
>>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
>>> Reported-by: Dirk Sihling <dsihling(a)web.de>
>>> Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>> ---
>>> config/grub2/default | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/config/grub2/default b/config/grub2/default
>>> index c1b78237e..127d33445 100644
>>> --- a/config/grub2/default
>>> +++ b/config/grub2/default
>>> @@ -1,6 +1,6 @@
>>> GRUB_TIMEOUT=5
>>> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>>> GRUB_DEFAULT=saved
>>> -GRUB_CMDLINE_LINUX="panic=10"
>>> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>>> GRUB_DISABLE_RECOVERY="true"
>>> GRUB_BACKGROUND="/boot/grub/splash.png"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices
2022-05-16 18:38 ` Peter Müller
@ 2022-05-17 11:22 ` Michael Tremer
0 siblings, 0 replies; 5+ messages in thread
From: Michael Tremer @ 2022-05-17 11:22 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]
Hello Peter,
> On 16 May 2022, at 19:38, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Hello Michael,
>
> thanks for your mail, which I unfortunately noticed too late.
LOL
> So, we have this patch in "next" for the time being, which I consider acceptable, since
> it will not reach anybody aside people running IPFire from the "unstable" tree - which
> is just as the name implies.
Indeed this change will only affect new installations from next and not change any existing ones.
> Feel free to revert the patch in "next" at your discretion. I do, however, not consider
> it overly problematic to stay there. :-)
Not right now, but there is more required to make this work. I will need some time to find out how to do this and until then this sadly will have to block the release:
See my latest comment here: https://bugzilla.ipfire.org/show_bug.cgi?id=12862#c37
-Michael
>
> Thanks, and best regards,
> Peter Müller
>
>
>> Please do not merge this yet.
>>
>> This will have to go into c168, but I am not entirely sure what side-effects it might have for those people who have been running their systems on c167 and did a reboot.
>>
>> -Michael
>>
>>> On 16 May 2022, at 16:17, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>
>>> Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>
>>>> This has changed in dracut 24 and we have used various hacks to enable
>>>> this behaviour again when it would have been so easy to just enable this
>>>> parameter.
>>>> Fixes: #12862 - Upgrade from Core 166 to 167 does not use RAID anymore
>>>> Reported-by: Dirk Sihling <dsihling(a)web.de>
>>>> Reported-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>>>> ---
>>>> config/grub2/default | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> diff --git a/config/grub2/default b/config/grub2/default
>>>> index c1b78237e..127d33445 100644
>>>> --- a/config/grub2/default
>>>> +++ b/config/grub2/default
>>>> @@ -1,6 +1,6 @@
>>>> GRUB_TIMEOUT=5
>>>> GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
>>>> GRUB_DEFAULT=saved
>>>> -GRUB_CMDLINE_LINUX="panic=10"
>>>> +GRUB_CMDLINE_LINUX="rd.auto panic=10"
>>>> GRUB_DISABLE_RECOVERY="true"
>>>> GRUB_BACKGROUND="/boot/grub/splash.png"
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-17 11:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 14:48 [PATCH] dracut: Enable automatic assembly of any RAID/LVM devices Michael Tremer
2022-05-16 15:17 ` Peter Müller
2022-05-16 15:18 ` Michael Tremer
2022-05-16 18:38 ` Peter Müller
2022-05-17 11:22 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox