* [PATCH] header.pl: Add reference to colors.txt into header.pl
@ 2023-03-16 10:34 Adolf Belka
2023-03-17 16:11 ` Bernhard Bitsch
0 siblings, 1 reply; 2+ messages in thread
From: Adolf Belka @ 2023-03-16 10:34 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
- With change of common css entries into header.pl with commit
https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=b52a84ddc77f9db7e4ad7b129f21fbf528c6f990
I had missed that color20 and color22 etc, that come from colors.txt, are not known in
header.pl so that the alternate colours in tables were missing. Even though I tested the
previous commit I obviously did not look well enough because I missed that the tables
had no alternate colours. I just found it now when looking at Core Update 174 Testing.
- Confirmed by copying this version of header.pl into my CU174 Testing system and the
alternate colour rows came back again as they should be. I am sure now that they are
correct.
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
| 3 +++
1 file changed, 3 insertions(+)
--git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
index 955ed2646..3f80ce9b4 100644
--- a/config/cfgroot/header.pl
+++ b/config/cfgroot/header.pl
@@ -17,6 +17,9 @@ use HTML::Entities();
use Socket;
use Time::Local;
+our %color = ();
+&General::readhash("/srv/web/ipfire/html/themes/ipfire/include/colors.txt", \%color);
+
$|=1; # line buffering
$Header::revision = 'final';
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] header.pl: Add reference to colors.txt into header.pl
2023-03-16 10:34 [PATCH] header.pl: Add reference to colors.txt into header.pl Adolf Belka
@ 2023-03-17 16:11 ` Bernhard Bitsch
0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Bitsch @ 2023-03-17 16:11 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 16.03.2023 um 11:34 schrieb Adolf Belka:
> - With change of common css entries into header.pl with commit
> https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=b52a84ddc77f9db7e4ad7b129f21fbf528c6f990
> I had missed that color20 and color22 etc, that come from colors.txt, are not known in
> header.pl so that the alternate colours in tables were missing. Even though I tested the
> previous commit I obviously did not look well enough because I missed that the tables
> had no alternate colours. I just found it now when looking at Core Update 174 Testing.
> - Confirmed by copying this version of header.pl into my CU174 Testing system and the
> alternate colour rows came back again as they should be. I am sure now that they are
> correct.
>
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/cfgroot/header.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
> index 955ed2646..3f80ce9b4 100644
> --- a/config/cfgroot/header.pl
> +++ b/config/cfgroot/header.pl
> @@ -17,6 +17,9 @@ use HTML::Entities();
> use Socket;
> use Time::Local;
>
> +our %color = ();
> +&General::readhash("/srv/web/ipfire/html/themes/ipfire/include/colors.txt", \%color);
> +
> $|=1; # line buffering
>
> $Header::revision = 'final';
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-17 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 10:34 [PATCH] header.pl: Add reference to colors.txt into header.pl Adolf Belka
2023-03-17 16:11 ` Bernhard Bitsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox