public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [PATCH] core205: Ship suricata-reporter
@ 2026-09-10 13:17 Adolf Belka
  2026-09-10 13:17 ` [PATCH] suricata-reporter: Fix Bug-14048 incorrect suricata-report-cron file used Adolf Belka
  0 siblings, 1 reply; 3+ messages in thread
From: Adolf Belka @ 2026-09-10 13:17 UTC (permalink / raw)
  To: development; +Cc: Adolf Belka

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 config/rootfiles/core/205/filelists/suricata-reporter | 1 +
 1 file changed, 1 insertion(+)
 create mode 120000 config/rootfiles/core/205/filelists/suricata-reporter

diff --git a/config/rootfiles/core/205/filelists/suricata-reporter b/config/rootfiles/core/205/filelists/suricata-reporter
new file mode 120000
index 000000000..23f2cd87d
--- /dev/null
+++ b/config/rootfiles/core/205/filelists/suricata-reporter
@@ -0,0 +1 @@
+../../../common/suricata-reporter
\ No newline at end of file
-- 
2.55.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] suricata-reporter: Fix Bug-14048 incorrect suricata-report-cron file used
  2026-09-10 13:17 [PATCH] core205: Ship suricata-reporter Adolf Belka
@ 2026-09-10 13:17 ` Adolf Belka
  2026-09-10 20:12   ` Michael Tremer
  0 siblings, 1 reply; 3+ messages in thread
From: Adolf Belka @ 2026-09-10 13:17 UTC (permalink / raw)
  To: development; +Cc: Adolf Belka

- suricata-report-cron was created in August 2025 in the suricata-reporter package. After
   this all updates were done in the suricata-report-cron placed in the config/suricata/
   directory in the ipfire-2.x repo but that file was not copied across into the /usr/bin
   directory
- This patch for the lfs file installs suricata-report-cron from the config/suricata/
   directory.
- Confirmed by checking the file contents in the build directory and also by installing
   the iso from the build.

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Fixes: Bug14048
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
---
 lfs/suricata-reporter | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lfs/suricata-reporter b/lfs/suricata-reporter
index c56e0b5da..5f82a48e4 100644
--- a/lfs/suricata-reporter
+++ b/lfs/suricata-reporter
@@ -1,7 +1,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2025 IPFire Team  <info@ipfire.org>                           #
+# Copyright (C) 2025-2026 IPFire Team  <info@ipfire.org>                      #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -88,5 +88,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 		/etc/suricata/reporter.conf
 	chown nobody:nobody /var/ipfire/suricata/reporter.conf
 
+	# Install suricata-report-cron file.
+	install -m 0644 $(DIR_SRC)/config/suricata/suricata-report-cron /usr/bin/suricata-report-cron
+
 	@rm -rf $(DIR_APP)
 	@$(POSTBUILD)
-- 
2.55.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] suricata-reporter: Fix Bug-14048 incorrect suricata-report-cron file used
  2026-09-10 13:17 ` [PATCH] suricata-reporter: Fix Bug-14048 incorrect suricata-report-cron file used Adolf Belka
@ 2026-09-10 20:12   ` Michael Tremer
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Tremer @ 2026-09-10 20:12 UTC (permalink / raw)
  To: Adolf Belka; +Cc: development

Hello Adolf,

Thank you for submitting this patch.

In addition to it, I have removed the cron script from the suricata-reporter tarball. That way we won’t get confused about two (almost) identical scripts any more.


  https://git.ipfire.org/?p=suricata-reporter.git;a=commitdiff;h=7322a71e81d65c063434fc7efda606bc75114079

All the best,
-Michael

> On 10 Sep 2026, at 14:17, Adolf Belka <adolf.belka@ipfire.org> wrote:
> 
> - suricata-report-cron was created in August 2025 in the suricata-reporter package. After
>   this all updates were done in the suricata-report-cron placed in the config/suricata/
>   directory in the ipfire-2.x repo but that file was not copied across into the /usr/bin
>   directory
> - This patch for the lfs file installs suricata-report-cron from the config/suricata/
>   directory.
> - Confirmed by checking the file contents in the build directory and also by installing
>   the iso from the build.
> 
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Fixes: Bug14048
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> lfs/suricata-reporter | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lfs/suricata-reporter b/lfs/suricata-reporter
> index c56e0b5da..5f82a48e4 100644
> --- a/lfs/suricata-reporter
> +++ b/lfs/suricata-reporter
> @@ -1,7 +1,7 @@
> ###############################################################################
> #                                                                             #
> # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2025 IPFire Team  <info@ipfire.org>                           #
> +# Copyright (C) 2025-2026 IPFire Team  <info@ipfire.org>                      #
> #                                                                             #
> # This program is free software: you can redistribute it and/or modify        #
> # it under the terms of the GNU General Public License as published by        #
> @@ -88,5 +88,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> /etc/suricata/reporter.conf
> chown nobody:nobody /var/ipfire/suricata/reporter.conf
> 
> + # Install suricata-report-cron file.
> + install -m 0644 $(DIR_SRC)/config/suricata/suricata-report-cron /usr/bin/suricata-report-cron
> +
> @rm -rf $(DIR_APP)
> @$(POSTBUILD)
> -- 
> 2.55.0
> 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-10 20:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 13:17 [PATCH] core205: Ship suricata-reporter Adolf Belka
2026-09-10 13:17 ` [PATCH] suricata-reporter: Fix Bug-14048 incorrect suricata-report-cron file used Adolf Belka
2026-09-10 20:12   ` Michael Tremer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox