collecty October 2016

collecty@lists.ipfire.org

1 participants
2 discussions

[PATCH] disk: Fix exporting graphs
by Arne Fitzenreiter 20 Oct '16

20 Oct '16

Colour module was not included Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org> --- src/collecty/plugins/disk.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/collecty/plugins/disk.py b/src/collecty/plugins/disk.py index a822eb2..fe5e0b9 100644 --- a/src/collecty/plugins/disk.py +++ b/src/collecty/plugins/disk.py @@ -25,6 +25,7 @@ import re from . import base +from ..colours import * from ..i18n import _ class GraphTemplateDiskBadSectors(base.GraphTemplate): -- 2.6.3

1 0

[PATCH] disk: Catch error for SMART devices w/o tmp sensors
by Arne Fitzenreiter 19 Oct '16

19 Oct '16

Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org> --- src/_collecty/blockdev.c | 8 +++++++- src/collecty/plugins/disk.py | 5 ++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/_collecty/blockdev.c b/src/_collecty/blockdev.c index 2c715b9..09d3994 100644 --- a/src/_collecty/blockdev.c +++ b/src/_collecty/blockdev.c @@ -296,8 +296,14 @@ PyObject* BlockDevice_get_temperature(PyObject* self) { uint64_t mkelvin; int r = sk_disk_smart_get_temperature(device->disk, &mkelvin); - if (r) + if (r) { + // Temperature not available but SMART is supported + if (errno == ENOENT) { + PyErr_Format(PyExc_OSError, "Device does not have a temperature"); + } + return NULL; + } // Convert the temperature to Kelvin return PyFloat_FromDouble((double)mkelvin / 1000.0); diff --git a/src/collecty/plugins/disk.py b/src/collecty/plugins/disk.py index 1b12c5c..a822eb2 100644 --- a/src/collecty/plugins/disk.py +++ b/src/collecty/plugins/disk.py @@ -267,7 +267,10 @@ class DiskObject(base.Object): if not self.is_smart_supported(): return "NaN" - return self.device.get_temperature() + try: + return self.device.get_temperature() + except OSError: + return "NaN" def get_bad_sectors(self): if not self.is_smart_supported(): -- 2.6.3

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

collecty October 2016