A returned error code 702 when using Zoneedit as provider now raise a request error with an corresponding message instead of a simple InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl stefan.schantl@ipfire.org --- src/ddns/providers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 3845193..dbe9261 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): elif output.startswith("<ERROR CODE="704""): raise DDNSRequestError(_("No valid FQDN was given.")) elif output.startswith("<ERROR CODE="702""): - raise DDNSInternalServerError + raise DDNSRequestError(_("Too frequent update requests have been sent."))
# If we got here, some other update error happened. raise DDNSUpdateError
Hi,
you are introducing whitespace errors there by using spaces instead of tabs.
-Michael
P.S. You can also send this patch to both mailing lists at the same time by using Cc.
On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
A returned error code 702 when using Zoneedit as provider now raise a request error with an corresponding message instead of a simple InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl stefan.schantl@ipfire.org
src/ddns/providers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 3845193..dbe9261 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): elif output.startswith("<ERROR CODE="704""): raise DDNSRequestError(_("No valid FQDN was given.")) elif output.startswith("<ERROR CODE="702""):
raise DDNSInternalServerError+ raise DDNSRequestError(_("Too frequent update requests have been sent.")) # If we got here, some other update error happened. raise DDNSUpdateError
Thanks for reviewing,
I really don't know why this happened. It seems my vim is miss- configured and translates tabs into spaces. When using nano as editor everything works fine....
I'll fix this issue and send a new patch.
-Stefan
Hi,
you are introducing whitespace errors there by using spaces instead of tabs.
-Michael
P.S. You can also send this patch to both mailing lists at the same time by using Cc.
On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
A returned error code 702 when using Zoneedit as provider now raise a request error with an corresponding message instead of a simple InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl stefan.schantl@ipfire.org
src/ddns/providers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 3845193..dbe9261 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): elif output.startswith("<ERROR CODE="704""): raise DDNSRequestError(_("No valid FQDN was given.")) elif output.startswith("<ERROR CODE="702""):
raise DDNSInternalServerError+ raise DDNSRequestError(_("Too frequent update requests have been sent.")) # If we got here, some other update error happened. raise DDNSUpdateError
A returned error code 702 when using Zoneedit as provider now raise a request error with an corresponding message instead of a simple InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl stefan.schantl@ipfire.org --- src/ddns/providers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 3845193..c653aa5 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): elif output.startswith("<ERROR CODE="704""): raise DDNSRequestError(_("No valid FQDN was given.")) elif output.startswith("<ERROR CODE="702""): - raise DDNSInternalServerError + raise DDNSRequestError(_("Too frequent update requests have been sent."))
# If we got here, some other update error happened. raise DDNSUpdateError
Reviewed-by: Michael Tremer michael.tremer@ipfire.org
ACK
On Fri, 2016-04-29 at 14:35 +0200, Stefan Schantl wrote:
A returned error code 702 when using Zoneedit as provider now raise a request error with an corresponding message instead of a simple InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl stefan.schantl@ipfire.org
src/ddns/providers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 3845193..c653aa5 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): elif output.startswith("<ERROR CODE="704""): raise DDNSRequestError(_("No valid FQDN was given.")) elif output.startswith("<ERROR CODE="702""):
raise DDNSInternalServerError
raise DDNSRequestError(_("Too frequent updaterequests have been sent.")) # If we got here, some other update error happened. raise DDNSUpdateError
-
Michael Tremer -
Stefan Schantl