network October 2015

network@lists.ipfire.org

2 participants
2 discussions

[network] [PATCH] pppoe-server: Check for valid network
by Stefan Schantl 06 Nov '15

06 Nov '15

The pppoe-server did not proper check if a valid IPv4 or IPv6 network has been specified. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- src/hooks/configs/pppoe-server | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/hooks/configs/pppoe-server b/src/hooks/configs/pppoe-server index 1ef3ba9..ac9b90a 100644 --- a/src/hooks/configs/pppoe-server +++ b/src/hooks/configs/pppoe-server @@ -42,6 +42,12 @@ hook_check_config_settings() { assert isset SUBNET assert isset MAX_SESSIONS + # Check input. + if ! ip_is_network "${SUBNET}"; then + log ERROR "Invalid subnet. Please provide a valid IPv6 or IPv4 network." + return ${EXIT_ERROR} + fi + local server for server in ${DNS_SERVERS}; do assert ipv4_is_valid "${server}" -- 2.4.3

2 2

[network] [PATCH] functions.ipv6: Fix doubble square bracket when calling assert
by Stefan Schantl 18 Oct '15

18 Oct '15

The assert check does not proper work when using doubble square backets, so the check fails for some unknown reasons. Removing one bracket will allow to successfully perform the assert check again. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- src/functions/functions.ipv6 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/functions/functions.ipv6 b/src/functions/functions.ipv6 index 9aedf84..2299135 100644 --- a/src/functions/functions.ipv6 +++ b/src/functions/functions.ipv6 @@ -399,7 +399,7 @@ ipv6_format() { } ipv6_addr_eq() { - assert [[ $# -eq 2 ]] + assert [ $# -eq 2 ] local addr1="${1}" local addr2="${2}" @@ -409,7 +409,7 @@ ipv6_addr_eq() { } ipv6_addr_gt() { - assert [[ $# -eq 2 ]] + assert [ $# -eq 2 ] local addr1="${1}" local addr2="${2}" -- 2.4.3

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

network October 2015